db: only write task event timers when changed #3948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-sanders
force-pushed
the
task_event_timers.7.8.x
branch
from
2363f80
to
eadec74
Compare
oliver-sanders
force-pushed
the
task_event_timers.7.8.x
branch
from
eadec74
to
769c5ea
Compare
|
Failing one test on CI: |
|
Does this affect master too? |
|
Yep - https://github.com/cylc/cylc-flow/pull/3596/files Will port once this is in, having trouble getting it through Travis ATM. |
oliver-sanders
force-pushed
the
task_event_timers.7.8.x
branch
from
769c5ea
to
362a72a
Compare
|
That should do it. |
MetRonnie
approved these changes
Nov 26, 2020
This was referenced Dec 2, 2020
oliver-sanders
added a commit
to oliver-sanders/cylc-flow
that referenced
this pull request
Dec 8, 2020
* foreport of cylc#3948
7 tasks
oliver-sanders
added a commit
to oliver-sanders/cylc-flow
that referenced
this pull request
Dec 8, 2020
* foreport of cylc#3948
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on from #3597
Close #3818
Only write task event timers to the database when they have changed.
Currently the entire DB table is rebuilt twice per main loop even when the scheduler is inactive or stalled.
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.