Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add glob to have review syntax highlight flow.cylc(.processed) files. #4264

Merged

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Jun 11, 2021

These changes partially address #4261 : Cylc Review is not identifying flow.cylc and flow.cylc.processed as files to be syntax highlighted.

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.py and
    conda-environment.yml.
  • Manual testing only: Legacy Software. To test check that cylc.flow and cylc.flow.processed are highlighted.
  • No change log entry: Will add a changelog entry covering all parts of Review: Small Bugs Meta Issue #4261
  • No documentation update required.

I think that this needs only 1 review.

@wxtim wxtim requested a review from dpmatthews June 11, 2021 13:01
@wxtim wxtim self-assigned this Jun 11, 2021
@wxtim wxtim added this to the cylc-7.8.x milestone Jun 11, 2021
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hjoliver hjoliver merged commit 1ee02c2 into cylc:7.8.x Jun 15, 2021
@wxtim wxtim mentioned this pull request Jun 21, 2021
4 tasks
@wxtim wxtim deleted the cylc-review-fixes.syntax-highlight-flow.cylc branch March 22, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants