Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.8.x Fix bug with task name as substring of task name. #4427

Merged
merged 3 commits into from
Sep 23, 2021

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented Sep 23, 2021

These changes close #3664 - 7.8.x sibling of #4426

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.py and conda-environment.yml.
  • Appropriate tests are included (unit and/or functional).
  • Appropriate change log entry included.
  • No documentation update required.

@hjoliver hjoliver self-assigned this Sep 23, 2021
@hjoliver hjoliver added the bug Something is wrong :( label Sep 23, 2021
@hjoliver hjoliver added this to the cylc-7.8.x milestone Sep 23, 2021
Copy link
Member

@dwsutherland dwsutherland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could reproduce the bug on my system:

(cylc7) sutherlander@cortex-vbox:c7simple$ cat suite.rc 

[scheduling]
    initial cycle point = 20210101
    [[dependencies]]
        [[[R1]]]
            graph = "foo | xfoo => bar"
(cylc7) sutherlander@cortex-vbox:c7simple$ cylc7 val foo
Valid for cylc-7.8.8-37-gf7a92
(cylc7) sutherlander@cortex-vbox:c7simple$ cylc7 val suite.rc 
Valid for cylc-7.8.8-40-g14bff

But works with changes.

@dwsutherland dwsutherland merged commit cfe9190 into cylc:7.8.x Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants