provided a alt list of states for filtering Cylc 8 tasks

[wxtim]

These changes partially address #4782

Features check-list
In cylc review...

• Provide a different set of task state filters for Cylc 8 and Cylc 7.
• Turn on waiting tasks by default if workflow is Cylc 8 (still under debate at Add "preparing" to list of filterable states. #4782 )
• Don't show tasks without jobs

Requirements check-list

• I have read CONTRIBUTING.md and added my name as a Code Contributor.
• Contains logically grouped changes (else tidy your branch by rebase).
• Does not contain off-topic changes (use other PRs for other changes).
• Applied any dependency changes to both setup.cfg and conda-environment.yml.
• Does not need tests - to be manually tested (see below)
• Appropriate change log entry included.
• No documentation update required.

How I tested

# global.cylc (end of)
[platforms]
    [[submitfail]]
        hosts = notahost
    [[submitted]]
        hosts = exvcylcdev01
        install target = exvcylcdev01
        communication method = poll
        submission polling intervals = P1Y

# flow.cylc
[scheduler]
    allow implicit tasks = true
[scheduling]
    initial cycle point = 1
    [[dependencies]]
        R1 = """
             expired & preparing & submitted  => waiting
             running & submit-failed & succeeded & failed =>waiting
            """

[runtime]
    [[submitted]]
        platform = submitted
    [[submit-failed]]
        platform = submitfail
    [[running]]
        script = while true; do sleep 30; done
    [[failed]]
        script = exit 1

and add the following hack to Cylc flow:

diff --git a/cylc/flow/task_job_mgr.py b/cylc/flow/task_job_mgr.py
index ab4174b55..9f3eeadba 100644
--- a/cylc/flow/task_job_mgr.py
+++ b/cylc/flow/task_job_mgr.py
@@ -1082,6 +1082,11 @@ class TaskJobManager:
         Return itask on a good preparation.
 
         """
+        if 'preparing' in itask.identity:
+            LOG.critical('Prevent task called preparing ever being marked as prepped.')
+            return False
+
+
         if itask.local_job_file_path:
             return itask

Note: Don't forget to check that the change hasn't done anything bad to Cylc Review's ability to read Cylc flow.

Another Note: Recent versions of the wrapper script may re-direct you to the wrong version of cylc review, I found it worthwhile running explicitly from a path - i.e. ${HOME}/cylc-7/bin/cylc review start

[datamel]

Minor points, working as expected for me. Thanks @wxtim.

[hjoliver]

Note to self: another Cylc 7 release needed. (I'll add to the next meeting agenda).