-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lack of errors/warnings for deprecated [runtime][<task>][remote]retrieve job logs *
settings
#4948
Conversation
cylc/flow/cfgspec/globalcfg.py
Outdated
Conf( | ||
'retrieve job logs', VDR.V_BOOLEAN, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why isn't there a default value for this (True
or False
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because history I'm afraid. We should make these defaults explicit - #4847
(Review pending response to this: #4944 (comment) ) |
From @dpmatthews explanatory comment on #4944:
So I guess you can just fix that here @MetRonnie, and we're good to go. |
490f4e7
to
2a34672
Compare
[runtime][<task>][remote]
[runtime][<task>][remote]retrieve job logs *
settings
2a34672
to
4511018
Compare
(Some functional test failures) |
After discussing, solution is to check blame and either stop using platforms for this test or remove the test |
4511018
to
00a0b3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Looks sane
- Local testing suggests that it works
00a0b3d
to
c09490e
Compare
c09490e
to
417bdcb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
These changes close #4944.
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
andconda-environment.yml
.