-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update misc. date-time representations to ISO 8601 #967
Merged
matthewrmshin
merged 8 commits into
cylc:119.iso8601-cycling
from
benfitzpatrick:iso8601.tweaks
Jun 5, 2014
Merged
Update misc. date-time representations to ISO 8601 #967
matthewrmshin
merged 8 commits into
cylc:119.iso8601-cycling
from
benfitzpatrick:iso8601.tweaks
Jun 5, 2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -60,15 +63,19 @@ def get_stop_state_summary(suite, owner=None, hostname=None, lines=None ): | |||
if line0.startswith( 'suite time' ) or \ | |||
line0.startswith( 'simulation time' ): | |||
# backward compatibility with pre-5.4.11 state dumps | |||
time_string = line0.rstrip().split(' : ')[1] | |||
global_summary["last_updated"] = time.time() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this work, now that import time
is removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-added the import time
.
matthewrmshin
added a commit
that referenced
this pull request
Jun 5, 2014
Update misc. date-time representations to ISO 8601
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates all remaining date-time representations in cylc to
use ISO 8601, including time zone information if useful.
@matthewrmshin, please review.