#119: speed up #974
Merged
#119: speed up #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -669,6 +672,23 @@ def remove_suiciding_tasks( self ): | |||
| self.remove( itask, 'suicide' ) | |||
|
|
|||
|
|
|||
| def _get_earliest_unsatisfied_cycle_point( self ): | |||
There was a problem hiding this comment.
The move to this function doesn't speed anything up, but it helped
profile this code block - I think we'll may need to look at this in the
future.
|
Looks good to me. Tests now passing in my environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The work on the #119 branch introduced some new bottlenecks into
the main daemon thread and in
cylc validatefor large suites.This pull request contains some fixes for those bottlenecks and
a couple of minor tweaks in non-cycling-affected code that were
spotted along the way.
The main loop non-sleep CPU time is now halved compared to
the current HEAD of the iso branch for a busy suite like this one:
https://gist.github.com/benfitzpatrick/7874308
This equates to 30% better than current HEAD of master.
For a suite that hangs around like this one:
https://gist.github.com/benfitzpatrick/7875481
then the main loop CPU time is halved compared to the current
HEAD of the iso branch, but approximately the same as master.
@arjclark, please review - @hjoliver, please take a look if you
get any spare time!