Feature color cylc message bubbles #1436
Draft
+122
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetRonnie
reviewed
Aug 29, 2023
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
MetRonnie
reviewed
Aug 30, 2023
src/components/cylc/MessageChip.vue
Outdated
Comment on lines
45
to
49
| ['this is a debug message', ''], | ||
| ['this is a info message', 'bg-grey'], | ||
| ['this is a warning message', 'bg-warning'], | ||
| ['this is an error message', 'bg-error'], | ||
| ['this is a critical message', 'bg-black font-weight-bold'], |
There was a problem hiding this comment.
This won't do anything until cylc/cylc-flow#5713 is addressed, but this is how it should be
Suggested change
| ['this is a debug message', ''], | |
| ['this is a info message', 'bg-grey'], | |
| ['this is a warning message', 'bg-warning'], | |
| ['this is an error message', 'bg-error'], | |
| ['this is a critical message', 'bg-black font-weight-bold'], | |
| ['DEBUG', ''], | |
| ['INFO', 'bg-grey'], | |
| ['WARNING', 'bg-warning'], | |
| ['ERROR', 'bg-error'], | |
| ['CRITICAL', 'bg-black font-weight-bold'], |
Can you take a look at
Line 70 in 63bdcc2
and add some logic to extract the severity level from the message which will be in the form SEVERITY:rest of message
There was a problem hiding this comment.
(I've got a fix for the "output vs ordinary message" logic at #1456)
8 tasks
added 2 commits
September 6, 2023 11:43
…rahamdawson/cylc-ui into feature-color-cylc-message-bubbles
MetRonnie
reviewed
Sep 6, 2023
| @@ -71,7 +71,8 @@ function jobMessageOutputs (jobNode) { | |||
| const ret = [] | |||
| let messageOutput | |||
|
|
|||
| for (const message of jobNode.node.messages || []) { | |||
| for (const messageString of jobNode.node.messages || []) { | |||
| const [level, message] = messageString.split(':') | |||
There was a problem hiding this comment.
Unfortunately as Oliver pointed out to me, we can't use String.split() as there could be multiple colons after the first severity level one. We'll have to use a regex here, I think something like
/^(?:(DEBUG|INFO|WARNING|ERROR|CRITICAL):)?(.*)/
|
Converted to draft pending resolution of cylc/cylc-flow#5714 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1276
Moved the message chip into a new component
Added functionality to style based on props
Note - at the moment the 'level' isn't coming through from the api so chip color is decided based on message label.
This will need addressing in the future.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.