351 #697
Draft
351 #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…we have active in tests.
…in the Workflow Service. This way we can have multiple components and views re-using the same queries that are merged. Or they can use different queries. When different queries are used (with different names, of course), the subscriptions for these queries are kept apart. This is useful when you have, for instance, a subscription like GScan's that has no variables, while Tree's query uses variables and different structure. The lifecycle of subscriptions is not maintained by the Workflow Service. It is now maintained via lifecycle methods of components and navigation guards of views. The code for that is in mixins. After these changes, the Workflow view can now display any View or Component that uses Subscriptions. And the Workflow view does not have to coordinate when widgets are created with their subscriptions. Unit tests and e2e tests will have to be updated, and new tests added as well. But with these changes, the Table view PR should be more easily merged. Besides fixing tests, we will also need to sort out the query merge that appears to have a few cases where queries are not merged correctly.
…, and dismissed (and removed from central data store)
Codecov Report
@@ Coverage Diff @@
## master #697 +/- ##
==========================================
- Coverage 88.65% 88.63% -0.03%
==========================================
Files 69 80 +11
Lines 1499 1566 +67
Branches 117 114 -3
==========================================
+ Hits 1329 1388 +59
- Misses 135 146 +11
+ Partials 35 32 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Ha! Had a post-it with a similar idea! But showing a small window at the bottom of the page and only in development mode. I like the idea to use a widget for that. Much easier 👍 |
|
|
This will be good to have 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
built on #543
closes #351
Developed for reviewing #543, and monitoring the performance of the workflowService, shows that active subscriptions and subscribers.
Ugly but effective:
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.