Skip to content

Commit

Permalink
mkdir: add racing MkdirAll test
Browse files Browse the repository at this point in the history
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
  • Loading branch information
cyphar committed Dec 6, 2024
1 parent 72283a0 commit 31cb517
Showing 1 changed file with 43 additions and 0 deletions.
43 changes: 43 additions & 0 deletions mkdir_linux_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
"os"
"path/filepath"
"runtime"
"sync"
"testing"

"github.com/stretchr/testify/assert"
Expand Down Expand Up @@ -497,3 +498,45 @@ func TestMkdirAllHandle_RacingDelete(t *testing.T) {
}
})
}

// Regression test for <https://github.com/opencontainers/runc/issues/4543>.
func TestMkdirAllHandle_RacingCreate(t *testing.T) {
withWithoutOpenat2(t, false, func(t *testing.T) {
threadRanges := []int{2, 4, 8, 16, 32, 64, 128, 512, 1024}
for _, numThreads := range threadRanges {
numThreads := numThreads
t.Run(fmt.Sprintf("threads=%d", numThreads), func(t *testing.T) {
// Do several runs to try to catch bugs.
const testRuns = 500
m := newRacingMkdirMeta()
for i := 0; i < testRuns; i++ {
root := t.TempDir()
unsafePath := "a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/x/y/z"

// Spawn many threads that will race against each other to
// create the same directory.
startCh := make(chan struct{})
var finishedWg sync.WaitGroup
for i := 0; i < numThreads; i++ {
finishedWg.Add(1)
go func() {
<-startCh
m.checkMkdirAllHandle_Racing(t, root, unsafePath, 0o711, nil)
finishedWg.Done()
}()
}

// Start all of the threads at the same time.
close(startCh)

// Wait for all of the racing threads to finish.
finishedWg.Wait()

// Clean up the root after each run so we don't exhaust all
// space in the tmpfs.
_ = os.RemoveAll(root)
}
})
}
})
}

0 comments on commit 31cb517

Please sign in to comment.