Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: find missing files when using all:true option #208

Merged
merged 7 commits into from
Apr 21, 2020
Merged

feat: find missing files when using all:true option #208

merged 7 commits into from
Apr 21, 2020

Conversation

bahmutov
Copy link
Contributor

@bahmutov bahmutov commented Apr 21, 2020 •
edited
Loading

  • closes Report all files when using all:true  #207
  • finds all files matching include, exclude if all: true (but always excluding the node_modules)
  • inserts missing files into .nyc_output/out.json file before generating reports (as placeholder objects, not real coverage)
  • confirms the results on CI

Screen Shot 2020-04-21 at 12 10 09 PM

Screen Shot 2020-04-21 at 12 18 32 PM

@bahmutov
Copy link
Contributor Author

Use in https://github.com/penx/storybook-code-coverage for #206 will show

Screen Shot 2020-04-21 at 12 51 35 PM

note: the merge reports operation could break, since I am inserting just an empty object

@bahmutov bahmutov changed the title Add all feat: find missing files when using all:true option Apr 21, 2020
@bahmutov bahmutov merged commit 2ce2d90 into master Apr 21, 2020
@bahmutov
Copy link
Contributor Author

🎉 This PR is included in version 3.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

rndmerle pushed a commit to rndmerle/code-coverage that referenced this pull request Apr 25, 2020
@bahmutov @rndmerle
feat: find missing files when using all:true option (cypress-io#208)
92b4a28 
* add example where a file should not be covered

* find files to include using globby

* insert empty coverage for missed files

* refactor a little

* change the icon for files without any statements

* confirm file not-covered is present in the final report

* search using default extension masks if include is not present
@DenrizSusam
Copy link

Is there a way to get correct coverage statistic?
(for example: for this report I want to see correct line coverage which also includes ones that are not covered

image
)

This was referenced Jul 8, 2021
Open
Open
@iFaxity iFaxity mentioned this pull request Apr 11, 2022
Closed
@emilyrohrbough emilyrohrbough deleted the add-all branch March 22, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Report all files when using all:true
2 participants
@bahmutov @DenrizSusam