Batch coverage data sent to combineCoverage to prevent timeouts

[aantes-st]

Description

Some users, including myself, have experienced task timeouts when large coverage reports are sent to the Node process. This change

• Adds support for environment variable sendCoverageBatchSize
• Adds a support utility function for retrieving and validating the variable
• Sends coverage to Node backend in batches of size sendCoverageBatchSize only if the environment variable is set and valid

This may address issue #455

Testing

In the existing full-report scenario, I was experiencing timeouts even when setting taskTimeout to 10+ minutes. With these changes, the coverage report is successfully constructed in seconds.

[cypress-app-bot]

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

[aantes-st]

@cacieprins The batching is currently hardcoded at every 500 keys, but this could be configurable, though that would require a lot more changes and is probably outside proper scope. Let me know what you think.

[cacieprins]

@aantes-st Thank you for your contribution! I have some questions before tackling the configurability decision:

• How did you arrive at the 500 mark?
• Do you know which part of the underlying task was slow? I'm curious if we could improve performance there instead of batching arbitrarily.

Thank you!

[aantes-st]

@aantes-st Thank you for your contribution! I have some questions before tackling the configurability decision:

• How did you arrive at the 500 mark?
• Do you know which part of the underlying task was slow? I'm curious if we could improve performance there instead of batching arbitrarily.

Thank you!

@cacieprins the 500 mark is arbitrarily chosen - there's no significance behind it. The performance issue seems to be in the transfer between support and task, where the coverage string is sent to the Node process. At first I thought it was due to the stringify and decode but after adding some debug statements, I found that the task handler never starts processing, indicating that the string never arrived.

[cacieprins]

@aantes-st That makes sense!

I think it would be best to make this configurable, however. Since the configuration value needs to be available in the browser, it can be attached to the env section of Cypress config, and accessed fairly easily in the command. I would recommend not batching if the env is not present.

How does that sound to you?

[aantes-st]

@aantes-st That makes sense!

I think it would be best to make this configurable, however. Since the configuration value needs to be available in the browser, it can be attached to the env section of Cypress config, and accessed fairly easily in the command. I would recommend not batching if the env is not present.

How does that sound to you?

@cacieprins sounds good! I'll get those changes committed shortly.

[aantes-st]

@cacieprins see the latest commits. If those look good, I will update the README file with information about using the new variable-based configuration.

[cacieprins]

Looks good to me!

[aantes-st]

Looks good to me!

@cacieprins Added README info about the environment variable and it's use. Should be all set!

Test investigation

[cacieprins]

Sorry for the premature approval, @aantes-st --

Can you add a test case to the test-apps dir that includes this environment variable? This test case should be constructed such that the batch logic is executed. Completely viable to set the env to a very low value to ensure that things are batched.

The tests in this project assert that coverage is 100% of the files that should be analyzed for coverage.

Once the test app is added, it needs to be included in the circle yml, both in the jobs matrix - https://github.com/cypress-io/code-coverage/blob/master/.circleci/config.yml#L146 and the requires list - https://github.com/cypress-io/code-coverage/blob/master/.circleci/config.yml#L172

Thank you!

[aantes-st]

@cacieprins I've added the test-app. I am not sure if/how the outcome is asserted (the check-coverage script?), but I did validate that all files are present in the coverage report output.

[cypress-app-bot]

🎉 This PR is included in version 3.13.5 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀