Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Write section on how to run cypress without an X11 server #4017

Merged
merged 3 commits into from
Jul 15, 2021

Conversation

mrmeku
Copy link
Contributor

@mrmeku mrmeku commented Jul 9, 2021

@netlify
Copy link

netlify bot commented Jul 9, 2021

👷 Deploy request for cypress-docs pending review.
Visit the deploys page to approve it

🔨 Explore the source changes: 43a3985

@CLAassistant
Copy link

CLAassistant commented Jul 9, 2021

CLA assistant check
All committers have signed the CLA.

@cowboy cowboy requested a review from a team July 9, 2021 14:09
@cowboy
Copy link
Contributor

cowboy commented Jul 9, 2021

@mrmeku this looks great. One request: can you also link to this from the Launching Browsers "Electron Browser" section in the docs?

@jennifer-shehane
Copy link
Member

@mrmeku Could you please sign our CLA? It's required for each repo separately. Thanks!

@jennifer-shehane jennifer-shehane changed the base branch from master to 8.0-release July 15, 2021 18:41
@jennifer-shehane
Copy link
Member

Updating the base branch to 8.0

@jennifer-shehane jennifer-shehane mentioned this pull request Jul 15, 2021
8 tasks
@jennifer-shehane
Copy link
Member

Thanks @mrmeku again for all the work!

@jennifer-shehane jennifer-shehane merged commit beee857 into cypress-io:8.0-release Jul 15, 2021
@mrmeku
Copy link
Contributor Author

mrmeku commented Jul 19, 2021

@jennifer-shehane Thanks for being a great repo maintainer. I just wanted to mention that this has been one of the least painful open source contributions I've done in years. Thank the whole team for me if you could

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants