Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update client certificates docs #4030

Merged
merged 2 commits into from
Jul 16, 2021

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Jul 15, 2021

  • Fix links that did not go to client-certificates doc
  • Add History to client certs and config pages to specify when this feature is added
  • Fix reference of where this should live (should be cypress.json, not cypress.env.json)
  • Rearrange Syntax

I’m on the fence about my updates to the Syntax section. I like tables for the properties, but maybe this isn’t clearer than the list before? Thoughts?

Before

Screen Shot 2021-07-15 at 1 28 27 PM

After

localhost_3000_guides_references_client-certificates (1)

@jennifer-shehane jennifer-shehane requested a review from cowboy July 15, 2021 18:39
Copy link
Contributor

@cowboy cowboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is WAY better than what I had! 💯 🎉 🥳

@cowboy
Copy link
Contributor

cowboy commented Jul 16, 2021

PS. I'm so impressed by your use of tables that I'm going to start using them instead of CSS for all my site layouts!

@jennifer-shehane
Copy link
Member Author

Do not bring my memories back to those days. 😑

@jennifer-shehane jennifer-shehane merged commit 1afdaa9 into 8.0-release Jul 16, 2021
@jennifer-shehane jennifer-shehane deleted the client-cert-cleanup branch July 16, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants