Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects return type of custom commands #4954

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

A-Shleifman
Copy link
Contributor

Changes:

  • Return type of custom commands: Chainable<Element> => Chainable<JQuery<HTMLElement>>
  • Removes /// <reference types="cypress" /> as we already get these types from tsconfig.json#compilerOptions.types

closes cypress-io/cypress#24416

@netlify
Copy link

netlify bot commented Jan 3, 2023

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 6abdb2c

@vercel
Copy link

vercel bot commented Jan 3, 2023

@A-Shleifman is attempting to deploy a commit to the Cypress Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Jan 3, 2023

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented Jan 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cypress-documentation ✅ Ready (Inspect) Visit Preview Jan 3, 2023 at 11:01PM (UTC)

@elylucas elylucas merged commit 2fe8c55 into cypress-io:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prevSubject: 'element' is disallowed by current types
5 participants