Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add qualified plugin #5410

Closed
wants to merge 2 commits into from
Closed

Conversation

elevatebart
Copy link
Contributor

@elevatebart elevatebart commented Aug 3, 2023

Add qualified plugin for sales

@netlify
Copy link

netlify bot commented Aug 3, 2023

Deploy Preview for benevolent-cat-040f48 ready!

Name Link
🔨 Latest commit 5561e96
🔍 Latest deploy log https://app.netlify.com/sites/benevolent-cat-040f48/deploys/64cd3566ec76680008710a09
😎 Deploy Preview https://deploy-preview-5410--benevolent-cat-040f48.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@elevatebart elevatebart marked this pull request as ready for review August 3, 2023 16:22
@@ -0,0 +1,29 @@
module.exports = async function fullStory({ context, options }) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming this block was inspired by the fullstory implementation, but the function should get it's own name 😄

name: 'docusaurus-plugin-qualified',
injectHtmlTags({ content }) {
if (!isProd) {
return {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to return an empty object specifically or is this just a short circuit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is only a short circuit to avoid pollution

@jaffrepaul
Copy link
Contributor

jaffrepaul commented Aug 4, 2023

@elevatebart all of the additional plugins add non-insignificant time to page load and additional resources to fetch. What exactly does this plugin do? I'm sure there's value to the sales & marketing teams but I'd like for the PR description to indicate purpose and value so we have context 🙏

@elevatebart
Copy link
Contributor Author

@elevatebart all of the additional plugins add non-insignificant time to page load and additional resources to fetch. What exactly does this plugin do? I'm sure there's value to the sales & marketing teams but I'd like for the PR description to indicate purpose and value so we have context 🙏

Unfortunately I have no idea I will let Ben Z and Kelly C explain. I am the messenger.

Sorry for the hustle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants