-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add qualified plugin #5410
Conversation
✅ Deploy Preview for benevolent-cat-040f48 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -0,0 +1,29 @@ | |||
module.exports = async function fullStory({ context, options }) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assuming this block was inspired by the fullstory implementation, but the function should get it's own name 😄
name: 'docusaurus-plugin-qualified', | ||
injectHtmlTags({ content }) { | ||
if (!isProd) { | ||
return {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need to return an empty object specifically or is this just a short circuit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is only a short circuit to avoid pollution
@elevatebart all of the additional plugins add non-insignificant time to page load and additional resources to fetch. What exactly does this plugin do? I'm sure there's value to the sales & marketing teams but I'd like for the PR description to indicate purpose and value so we have context 🙏 |
Unfortunately I have no idea I will let Ben Z and Kelly C explain. I am the messenger. Sorry for the hustle. |
Add qualified plugin for sales