Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct links in "Migrating from Protractor to Cypress" #5658

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

MikeMcC399
Copy link
Contributor

Issues

  • A link to https://github.com/cypress-io/cypress/discussions/new results in the warning "Sorry, we didn't recognize that category!".
  • The target of the anchor link /guides/core-concepts/introduction-to-cypress#Commands-Are-Not-Promises does not exist on that page.
  • The target of the anchor link /guides/continuous-integration/introduction#CircleCI does not exist on that page.
  • The target of the anchor link /guides/references/best-practices#Having-tests-rely-on-the-state-of-previous-tests does not match the auto-generated bookmark exactly.

Changes

In End-to-End Testing > Migrating from Other Frameworks > Migrating from Protractor to Cypress the following links are corrected:

Copy link

netlify bot commented Feb 15, 2024

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 03c03e3

Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for benevolent-cat-040f48 ready!

Name Link
🔨 Latest commit 03c03e3
🔍 Latest deploy log https://app.netlify.com/sites/benevolent-cat-040f48/deploys/65cdf556731f8600082ae888
😎 Deploy Preview https://deploy-preview-5658--benevolent-cat-040f48.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399 MikeMcC399 marked this pull request as ready for review February 15, 2024 11:33
@jennifer-shehane jennifer-shehane merged commit 570e3f0 into cypress-io:main Feb 15, 2024
9 checks passed
@MikeMcC399 MikeMcC399 deleted the links/protractor branch February 15, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants