-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updates to CI and the CI Examples #580
Conversation
emilyrohrbough
commented
Dec 6, 2022
- Update CI pipelines & fix errors & hopefully the automatic release when merged to master
- Update CI examples to show pulling the latest node versions/images vs node which is now deprecated
- Bump the project's node version to 14
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
@@ -9,13 +9,13 @@ jobs: | |||
# Job names can contain alphanumeric characters and '_', cannot start with a number | |||
- job: Cypress_e2e_tests | |||
pool: | |||
vmImage: 'ubuntu-16.04' | |||
vmImage: 'ubuntu-latest' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per actions/runner-images#3287:
Traditional 5-years support of Ubuntu 16.04 by Canonical ends in April, 2021. To keep our environment updated and secured, we will remove Ubuntu 16.04 from GitHub on September 20, 2021, and from Azure DevOps on October 18, 2021.
This failed to run: https://cypress-io.visualstudio.com/cypress-example-kitchensink/_build/results?buildId=1642&view=logs&j=d2f18934-c168-59e0-ad20-3282681c6565
@@ -2,7 +2,7 @@ version: 2 | |||
jobs: | |||
test: | |||
docker: | |||
- image: cypress/base:10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cypress v12 dropped node 12 support. This is an example for users. Updated to pull latest.
@@ -13,7 +13,7 @@ cache: | |||
- cache/Cypress | |||
|
|||
test: | |||
image: cypress/base:10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cypress v12 dropped node 12 support. This is an example for users. Updated to pull latest.
@@ -20,7 +20,7 @@ blocks: | |||
jobs: | |||
- name: npm ci and cache | |||
commands: | |||
- nvm install 12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cypress v12 dropped node 12 support. This is an example for users. Updated to use the latest LTS node version.
@@ -1,8 +1,7 @@ | |||
language: node_js | |||
|
|||
node_js: | |||
# Node 10.3+ includes npm@6 which has good "npm ci" command | |||
- 10.8 | |||
- 18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cypress v12 dropped node 12 support. This is an example for users. Updated to use the latest LTS node version.
@@ -9,7 +9,7 @@ jobs: | |||
steps: | |||
- task: NodeTool@0 | |||
inputs: | |||
versionSpec: '12.x' | |||
versionSpec: '18.x' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cypress v12 dropped node 12 support. This is an example for users. Updated to use the latest LTS node version.
@@ -2,7 +2,7 @@ | |||
# https://documentation.codeship.com/pro/languages-frameworks/nodejs/ | |||
|
|||
# use Cypress provided image with all dependencies included | |||
FROM cypress/base:10 | |||
FROM cypress/base:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cypress v12 dropped node 12 support. This is an example for users. Updated to pull latest.
@@ -2,7 +2,7 @@ pipeline { | |||
agent { | |||
// this image provides everything needed to run Cypress | |||
docker { | |||
image 'cypress/base:10' | |||
image 'cypress/base:latest' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cypress v12 dropped node 12 support. This is an example for users. Updated to pull latest.
@@ -77,7 +76,7 @@ | |||
"yaml-lint": "1.2.4" | |||
}, | |||
"engines": { | |||
"node": ">=12" | |||
"node": "^14.0.0 || ^16.0.0 || >=18.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Match Cypress's node engines.
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
@@ -60,9 +60,8 @@ | |||
}, | |||
"devDependencies": { | |||
"@bahmutov/print-env": "1.2.0", | |||
"@cypress/eslint-plugin-dev": "5.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This had peer dependencies on eslint-plugin-mocha v4
, which wanted eslint v4
. To keep the newer version of eslint, removed @cypress/eslint-plugin-dev
The base build image needs updated for the cypress-example-kitchensink project in netlify. The is currently is I don’t have access to the project settings to bump this myself. Have reached out to have this resolved by somone with access. |
🎉 This PR is included in version 1.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |