chore: update name for graphql batch operations (#25610)

* feat: update name for graphql batch operations * Validate selection kind * Update packages/data-context/src/sources/CloudDataSource.ts Co-authored-by: Tim Griesser <tgriesser10@gmail.com> --------- Co-authored-by: Tim Griesser <tgriesser10@gmail.com>
cypress-io · Jan 30, 2023 · 1f9ae86 · 1f9ae86 · cypress-bot · Jan 30, 2023
1 parent 86f92da
commit 1f9ae86
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/packages/data-context/src/sources/CloudDataSource.ts b/packages/data-context/src/sources/CloudDataSource.ts
@@ -402,11 +402,26 @@ function namedExecutionDocument (document: DocumentNode) {
       }
 
       hasReplaced = true
+
+      const selectionSet = new Set()
+
+      op.selectionSet.selections.forEach((s) => {
+        if (s.kind === 'Field') {
+          selectionSet.add(s.name.value)
+        }
+      })
+
+      let operationName = 'batchTestRunnerExecutionQuery'
+
+      if (selectionSet.size > 0) {
+        operationName = `${operationName}_${Array.from(selectionSet).sort().join('_')}`
+      }
+
       const namedOperationNode: OperationDefinitionNode = {
         ...op,
         name: {
           kind: 'Name',
-          value: 'batchTestRunnerExecutionQuery',
+          value: operationName,
         },
       }
 

diff --git a/packages/frontend-shared/cypress/e2e/e2ePluginSetup.ts b/packages/frontend-shared/cypress/e2e/e2ePluginSetup.ts
@@ -239,7 +239,7 @@ async function makeE2ETasks () {
 
           operationCount[operationName ?? 'unknown']++
 
-          if (operationName === 'batchTestRunnerExecutionQuery' && remoteGraphQLInterceptBatched) {
+          if (operationName?.startsWith('batchTestRunnerExecutionQuery') && remoteGraphQLInterceptBatched) {
             const fn = remoteGraphQLInterceptBatched
             const keys: string[] = []
             const values: Promise<any>[] = []