fix: Google Chrome for testing - version not parsed correctly

cypress-io · Nov 5, 2023 · 46843e9 · 46843e9
1 parent 5dbebe6
commit 46843e9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/cli/CHANGELOG.md b/cli/CHANGELOG.md
@@ -5,6 +5,7 @@ _Released 11/7/2023 (PENDING)_
 
 **Bugfixes:**
 
+- Fixed Google Chrome for Testing version parsing issue. Fixes [#28123](https://github.com/cypress-io/cypress/issues/28123).
 - Fixed an issue determining visibility when an element is hidden by an ancestor with a shared edge. Fixes [#27514](https://github.com/cypress-io/cypress/issues/27514).
 - Fixed an issue where in chromium based browsers, global style updates can trigger flooding of font face requests in DevTools and Test Replay. This can affect performance due to the flooding of messages in CDP. Fixes [#28150](https://github.com/cypress-io/cypress/issues/28150) and [#28215](https://github.com/cypress-io/cypress/issues/28215).
 - Fixed an issue with 'other' targets (e.g. pdf documents embedded in an object tag) not fully loading. Fixes [#28228](https://github.com/cypress-io/cypress/issues/28228) and [#28162](https://github.com/cypress-io/cypress/issues/28162).

diff --git a/packages/launcher/lib/known-browsers.ts b/packages/launcher/lib/known-browsers.ts
@@ -34,7 +34,8 @@ export const knownBrowsers: Browser[] = [
     family: 'chromium',
     channel: 'stable',
     displayName: 'Chrome',
-    versionRegex: /Google Chrome (\S+)/m,
+    // Chrome for testing can be any stable, beta, dev or canary version
+    versionRegex: /Google Chrome (?:for Testing )?(\S+)/m,
     binary: ['google-chrome', 'chrome', 'google-chrome-stable'],
     minSupportedVersion: MIN_CHROME_VERSION,
   },