fix: make NODE_ENV "production" for prod builds of launchpad (#25320)

cypress-io · Jan 3, 2023 · 5f536fe · 5f536fe · cypress-bot · Jan 3, 2023
1 parent 05b9f10
commit 5f536fe
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/frontend-shared/vite.config.mjs b/packages/frontend-shared/vite.config.mjs
@@ -150,6 +150,7 @@ export const makeConfig = (config = {}, plugins = {}) => {
     define: {
       'process.env': {
         CYPRESS_INTERNAL_ENV: 'development',
+        NODE_ENV: process.env.NODE_ENV,
       },
       // Fix to get cypress-plugin-tab to work in CT
       'process.version': '99',

diff --git a/scripts/gulp/tasks/gulpVite.ts b/scripts/gulp/tasks/gulpVite.ts
@@ -102,17 +102,16 @@ export function viteBuildApp () {
 export function viteBuildAndWatchApp () {
   return watchViteBuild('vite:build-watch-app', `yarn vite build --watch`, {
     cwd: monorepoPaths.pkgApp,
-    env: {
-      // ...process.env,
-      NODE_ENV: 'production',
-    },
   })
 }
 
 export function viteBuildLaunchpad () {
   return spawned('vite:build-launchpad', `yarn vite build --outDir dist`, {
     cwd: monorepoPaths.pkgLaunchpad,
     waitForExit: true,
+    env: {
+      NODE_ENV: 'production',
+    },
   })
 }