fix: webpack-preprocessor-lazy-load - React lazy load breaks webpack …

…config fix: webpack-preprocessor-lazy-load - React lazy load breaks webpack config
cypress-io · Jan 20, 2021 · 685f11e · 685f11e
1 parent 012d58c
commit 685f11e
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/npm/webpack-preprocessor/index.ts b/npm/webpack-preprocessor/index.ts
@@ -198,6 +198,7 @@ const preprocessor: WebpackPreprocessor = (options: PreprocessorOptions = {}): F
       output: {
         path: path.dirname(outputPath),
         filename: path.basename(outputPath),
+        ...(options.webpackOptions?.output ?? {}),
       },
     })
     .tap((opts) => {

diff --git a/npm/webpack-preprocessor/test/unit/index.spec.js b/npm/webpack-preprocessor/test/unit/index.spec.js
@@ -151,6 +151,20 @@ describe('webpack preprocessor', function () {
         })
       })
 
+      it('adds output options when user output options are non-default', function () {
+        const options = { webpackOptions: { output: { publicPath: '/' } } }
+
+        return this.run(options).then(() => {
+          expect(webpack).to.be.calledWithMatch({
+            output: {
+              path: 'output',
+              filename: 'output.js',
+              publicPath: '/',
+            },
+          })
+        })
+      })
+
       describe('devtool', function () {
         beforeEach((() => {
           sinon.stub(typescriptOverrides, 'overrideSourceMaps')