chore(deps): update dependency eslint-plugin-cypress to v3 (#30136)

* chore(deps): update dependency eslint-plugin-cypress to v3

* empty commit

* Fix cypress eslint errors in system tests

* Update snapshots after changing protocol tests.

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>

package.json

@@ -146,7 +146,7 @@
     "electron-builder": "^23.6.0",
     "enzyme-adapter-react-16": "1.12.1",
     "eslint": "^8.56.0",
-    "eslint-plugin-cypress": "2.11.2",
+    "eslint-plugin-cypress": "3.5.0",
     "eslint-plugin-graphql": "4.0.0",
     "eslint-plugin-import": "2.25.4",
     "eslint-plugin-json-format": "2.0.1",

system-tests/projects/protocol/cypress/e2e/font-flooding.cy.js

@@ -1,11 +1,13 @@
 describe('font flooding', () => {
   it('will not occur', () => {
     cy.visit('cypress/fixtures/font-flooding.html')
-    cy.get('#btn').click().should('have.text', 'Clicked')
+    cy.get('#btn').click()
+    cy.get('#btn').should('have.text', 'Clicked')
   })
 
   it('will not occur', () => {
     cy.visit('cypress/fixtures/font-flooding.html')
-    cy.get('#btn').click().should('have.text', 'Clicked')
+    cy.get('#btn').click()
+    cy.get('#btn').should('have.text', 'Clicked')
   })
 })

system-tests/projects/protocol/cypress/e2e/test-isolation.cy.js

@@ -5,47 +5,56 @@ describe('test isolation', { baseUrl: null }, () => {
     it('test 1', () => {
       cy.visit('cypress/fixtures/dom-with-browser-interactions.html')
       cy.wait(1000, { log: false })
-      cy.get('#text-target').type('abc').should('have.value', 'abc')
+      cy.get('#text-target').type('abc')
+      cy.get('#text-target').should('have.value', 'abc')
     })
 
     it('test 2', () => {
-      cy.get('#text-target').type('def').should('have.value', 'abcdef')
+      cy.get('#text-target').type('def')
+      cy.get('#text-target').should('have.value', 'abcdef')
     })
 
     it('test 3', () => {
-      cy.get('#text-target').type('ghi').should('have.value', 'abcdefghi')
+      cy.get('#text-target').type('ghi')
+      cy.get('#text-target').should('have.value', 'abcdefghi')
     })
 
     it('test 4', () => {
-      cy.get('#text-target').type('!').should('have.value', 'abcdefghi!')
+      cy.get('#text-target').type('!')
+      cy.get('#text-target').should('have.value', 'abcdefghi!')
 
       cy.visit('cypress/fixtures/dom-with-browser-interactions.html')
       cy.wait(1000, { log: false })
-      cy.get('#text-target').type('abc').should('have.value', 'abc')
+      cy.get('#text-target').type('abc')
+      cy.get('#text-target').should('have.value', 'abc')
     })
 
     it('test 5', () => {
-      cy.get('#text-target').type('!').should('have.value', 'abc!')
+      cy.get('#text-target').type('!')
+      cy.get('#text-target').should('have.value', 'abc!')
     })
   })
 
   describe('test isolation true', { testIsolation: true }, () => {
     it('test 6', () => {
       cy.visit('cypress/fixtures/dom-with-browser-interactions.html')
       cy.wait(1000, { log: false })
-      cy.get('#text-target').type('abc').should('have.value', 'abc')
+      cy.get('#text-target').type('abc')
+      cy.get('#text-target').should('have.value', 'abc')
     })
 
     it('test 7', () => {
       cy.visit('cypress/fixtures/dom-with-browser-interactions.html')
       cy.wait(1000, { log: false })
-      cy.get('#text-target').type('def').should('have.value', 'def')
+      cy.get('#text-target').type('def')
+      cy.get('#text-target').should('have.value', 'def')
     })
   })
 
   describe('test isolation false', { testIsolation: false }, () => {
     it('test 8', () => {
-      cy.get('#text-target').type('abc').should('have.value', 'defabc')
+      cy.get('#text-target').type('abc')
+      cy.get('#text-target').should('have.value', 'defabc')
     })
   })
 })

system-tests/projects/protocol/src/components/HelloEarth.cy.jsx

@@ -4,15 +4,13 @@ import HelloEarth from './HelloEarth.jsx'
 describe('<HelloEarth />', () => {
   it('test 1', () => {
     cy.mount(<HelloEarth />)
-    cy.get('#earth-text')
-    .type('Hello Earth')
-    .should('have.value', 'Hello Earth')
+    cy.get('#earth-text').type('Hello Earth')
+    cy.get('#earth-text').should('have.value', 'Hello Earth')
   })
 
   it('test 2', () => {
     cy.mount(<HelloEarth />)
-    cy.get('#earth-text')
-    .type('Where\'s Mars?')
-    .should('have.value', 'Where\'s Mars?')
+    cy.get('#earth-text').type('Where\'s Mars?')
+    cy.get('#earth-text').should('have.value', 'Where\'s Mars?')
   })
 })

system-tests/projects/protocol/src/components/HelloMars.cy.jsx

@@ -4,15 +4,13 @@ import HelloMars from './HelloMars.jsx'
 describe('<HelloMars />', () => {
   it('test 1', () => {
     cy.mount(<HelloMars />)
-    cy.get('#mars-text')
-    .type('Hello Mars')
-    .should('have.value', 'Hello Mars')
+    cy.get('#mars-text').type('Hello Mars')
+    cy.get('#mars-text').should('have.value', 'Hello Mars')
   })
 
   it('test 2', () => {
     cy.mount(<HelloMars />)
-    cy.get('#mars-text')
-    .type('Where\'s Earth?')
-    .should('have.value', 'Where\'s Earth?')
+    cy.get('#mars-text').type('Where\'s Earth?')
+    cy.get('#mars-text').should('have.value', 'Where\'s Earth?')
   })
 })

yarn.lock

@@ -15066,12 +15066,12 @@ eslint-module-utils@^2.1.1, eslint-module-utils@^2.7.2, eslint-module-utils@^2.8
   dependencies:
     debug "^3.2.7"
 
-eslint-plugin-cypress@2.11.2:
-  version "2.11.2"
-  resolved "https://registry.yarnpkg.com/eslint-plugin-cypress/-/eslint-plugin-cypress-2.11.2.tgz#a8f3fe7ec840f55e4cea37671f93293e6c3e76a0"
-  integrity sha512-1SergF1sGbVhsf7MYfOLiBhdOg6wqyeV9pXUAIDIffYTGMN3dTBQS9nFAzhLsHhO+Bn0GaVM1Ecm71XUidQ7VA==
+eslint-plugin-cypress@3.5.0:
+  version "3.5.0"
+  resolved "https://registry.yarnpkg.com/eslint-plugin-cypress/-/eslint-plugin-cypress-3.5.0.tgz#380ef5049ad80ebeca923db69e4aa96e72fcd893"
+  integrity sha512-JZQ6XnBTNI8h1B9M7wJSFzc48SYbh7VMMKaNTQOFa3BQlnmXPrVc4PKen8R+fpv6VleiPeej6VxloGb42zdRvw==
   dependencies:
-    globals "^11.12.0"
+    globals "^13.20.0"
 
 eslint-plugin-graphql@4.0.0:
   version "4.0.0"
@@ -17207,12 +17207,12 @@ global@~4.4.0:
     min-document "^2.19.0"
     process "^0.11.10"
 
-globals@^11.1.0, globals@^11.12.0:
+globals@^11.1.0:
   version "11.12.0"
   resolved "https://registry.yarnpkg.com/globals/-/globals-11.12.0.tgz#ab8795338868a0babd8525758018c2a7eb95c42e"
   integrity sha512-WOBp/EEGUiIsJSp7wcv/y6MO+lV9UoncWqxuFfm8eBwzWNgyfBd6Gz+IeKQ9jCmyhoH99g15M3T+QaVHFjizVA==
 
-globals@^13.19.0:
+globals@^13.19.0, globals@^13.20.0:
   version "13.24.0"
   resolved "https://registry.yarnpkg.com/globals/-/globals-13.24.0.tgz#8432a19d78ce0c1e833949c36adb345400bb1171"
   integrity sha512-AhO5QUcj8llrbG09iWhPU2B204J1xnPeL8kQmVorSsy+Sjj1sk8gIyh6cUocGmH4L0UuhAJy+hJMRA4mgA4mFQ==