-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
component testing: top of iframe sometimes hidden #16788
Comments
If you find the component with
to the element style, does it fix your issue? I'm seeing something similar locally but this is the only issue that is close enough to what's happening to me |
Thanks for the suggestion - I'm more looking for a solution that solves it for everyone out of the box, but it's likely to be something similar to what you are suggesting (some kind of minor CSS adjustment). |
Any update on a fix/workaround for this? |
I think @tgriesser made a fix for this that he only committed to Tim, would you mind terribly merging your fix into 9.X? |
Any update on this? Happy to create a PR with the commit cherry-picked if it helps :) |
@joshwooding thank you for asking. No update yet I am afraid. It would really help if you shared a repo where you see the problem and we could test the fix. |
I'll see if I'm able to reproduce this consistently. I know that when I encounter it I can apply #18649 locally and it fixes it. |
I was able to reproduce it @lmiller1990 I believe it's something to do with the scrolling of the command pane and setting the viewportHeight to above a certain value. My reproduction is here: https://github.com/joshwooding/cypress-react-template |
I believe the issue happens, on 9.X, under those conditions:
In this case, the initial scroll pushes the content above the fold. It does not happen all the time since it is a rendering race condition. I believe using I will review |
Current behavior
Sometimes the top of the iframe cannot be seen:
Desired behavior
Can see entire iframe.
Test code to reproduce
This branch does it: #16747
Go to packages/springboard and run yarn cypress:open:ct
Versions
The text was updated successfully, but these errors were encountered: