Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IATR](M0) Fetch run data with failed tests from Cloud #24440

Closed
warrensplayer opened this issue Oct 28, 2022 · 3 comments
Closed

[IATR](M0) Fetch run data with failed tests from Cloud #24440

warrensplayer opened this issue Oct 28, 2022 · 3 comments
Assignees
Labels
CT Issue related to component testing

Comments

@warrensplayer
Copy link
Contributor

warrensplayer commented Oct 28, 2022

Use the new GraphQL queries from the Cloud to fetch the data to populate the new "Failures" page

Description

The failures page will show test failures from the "most relevant" run to the current local environment. This will be determined by sending the last 100 git commit hashes to request related CloudRun information with the cloud GraphQL field relatedRunsForGitCommits developed here and then requesting the failed specs for the most recent run with the GraphQL field testFailuresByRunId developed here.

Out of scope

  • For M0, only the new Failures page will make use of these new fields. The cloud team is performing a spike here to look at what it will take to use the same logic to replace the algorithm currently used to determine the values for the RunStatusDots on the SpecsList page. The implementation of those changes will be in a future milestone for IATR.
  • A future milestone will introduce a badge shown in the left hand navigation within the "Failures" nav item to indicate if failures are present.

Technical Requirements

  • Leverage the pattern that was recently established to consolidate cloud status determination to the shared root component CloudViewerAndProject.
  • Query for and save the relevant run information in the store used in the CloudViewAndProject component for use in the Failures page for this milestone. (A future milestone will expand the use case to store the 4 most relevant runs. See "Out of scope" above.)
  • When visiting the "Failures" page, the relevant run information will be fetched from the store and used to query for the failed specs information to display on the page.

Cloud Epic: https://cypress-io.atlassian.net/browse/CYCLOUD-665

@warrensplayer warrensplayer changed the title "Run failures" API client [IATR] "Run failures" API client Oct 28, 2022
@warrensplayer warrensplayer changed the title [IATR] "Run failures" API client [IATR](V0) "Run failures" API client Oct 28, 2022
@warrensplayer warrensplayer changed the title [IATR](V0) "Run failures" API client [IATR](M0) Fetch run data with failed tests from Cloud Nov 3, 2022
@warrensplayer warrensplayer added the CT Issue related to component testing label Nov 3, 2022
@warrensplayer
Copy link
Contributor Author

@lmiller1990
Copy link
Contributor

I'm adding a bit of buffer to my vote. The way we currently test GraphQL calls is a bit messy, confusing and doesn't give me much confidence. I'd like to see some thought put into how we can effectively test and develop around the App <> Cloud seam. I also think testing for reviewers is going to be somewhat time consuming, so that's also included in my vote.

@warrensplayer
Copy link
Contributor Author

Blocked while waiting on completion of the related Cloud issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CT Issue related to component testing
Projects
None yet
Development

No branches or pull requests

2 participants