Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build 'create from React component' UI #24773

Closed
astone123 opened this issue Nov 22, 2022 · 4 comments
Closed

Build 'create from React component' UI #24773

astone123 opened this issue Nov 22, 2022 · 4 comments
Assignees
Labels
CT Issue related to component testing

Comments

@astone123
Copy link
Contributor

astone123 commented Nov 22, 2022

Create from React Component requires a slightly different user flow from Create from Vue Component. This is because we need to parse the selected file to determine whether there are any React components defined in the file that we can create a spec for.

Create all of the UI necessary to match the designs in Figma and mock the API interactions if it isn't completed yet.

Most of the UI is the same as Create from Vue except for the "Select a Component" view. This view should be created with a loading (for when we are parsing the file) and empty state (for when there are no React components defined in the file).

See the Create from React Component tech brief for guidance

@astone123 astone123 added the CT Issue related to component testing label Nov 22, 2022
@baus
Copy link

baus commented Nov 22, 2022

@baus
Copy link

baus commented Nov 22, 2022

As part of this issue, update the user docs to explain this feature. Should be similar to the work for Create from Vue Component

@ZachJW34 ZachJW34 self-assigned this Nov 28, 2022
@astone123 astone123 self-assigned this Nov 30, 2022
@ZachJW34 ZachJW34 removed their assignment Dec 1, 2022
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: in progress labels Dec 5, 2022
@cypress-bot cypress-bot bot added stage: review and removed stage: needs review The PR code is done & tested, needs review stage: review labels Dec 7, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 14, 2022

The code for this is done in cypress-io/cypress#24982, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 20, 2022

Released in 12.2.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.2.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CT Issue related to component testing
Projects
None yet
Development

No branches or pull requests

3 participants