feat: create from React component UI #24982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d763e1f.
…ate-from-react-server
…om/cypress-io/cypress into astone123/create-from-react-server
|
I got the same problem as @marktnoonan but I think it was due to usage with watch mode and refreshing too fast. |
ZachJW34
suggested changes
Dec 8, 2022
packages/app/src/specs/generators/component/ReactComponentGeneratorStepOne.vue
Show resolved
Hide resolved
astone123
commented
Dec 9, 2022
…ess-io/cypress into astone123/create-from-react-ui
ZachJW34
approved these changes
Dec 9, 2022
lmiller1990
approved these changes
Dec 11, 2022
There was a problem hiding this comment.
Couple of tiny things, but I think this looks good. Mainly curious about #24982 (comment).
| isDefault: item.isDefault, | ||
| }) | ||
|
|
||
| generateSpecFromSource.value = data?.generateSpecFromSource |
There was a problem hiding this comment.
Refactor later means refactor never - happy to live with this for now, but I hope we can start to think about how to get a handle of GraphQL. Things are getting quite messy, I think the core problem is we should be handling this on the back-end and giving the client a more well defined response in the first place. It would eliminate the need for the conditionals in the frontend.
|
Having an issue with dependencies (looks like Babel) after merging in changes from develop. See the latest pipeline runs. Working on this now |
lmiller1990
added a commit
that referenced
this pull request
Dec 19, 2022
* feat: server logic for create from React component (#24881) Co-authored-by: Ryan Manuel <ryanm@cypress.io> Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com> * fix: add default export detection (#24954) Co-authored-by: astone123 <adams@cypress.io> * update cache * update yarn.lock to fix builds * fix: compilation with webpack preprocessor * feat: create from React component UI (#24982) * feat: WIP server logic for create from React component * feat: add more tests; error handling * feat: WIP create from React UI * feat: PR feedback [run CI] * feat: try committing snapshot cache changes [run ci] * feat: try re-generating snapshot [run ci] * fix build * regenerate cache on darwin * update caches * Revert "feat: try re-generating snapshot [run ci]" This reverts commit d763e1f. * fix typing error * types * fix test * chore: try using react-docgen@6.0.0-alpha.3 * update test * regen linux snapshot * update snapshots for darwin * re-gen linux snapshot * yarn install * update snapshots * update snapshot metadata * update snapshots due to babel deps changing slightly * make react docgen a dep * update tests * revert * snapshots again?? * revert * update * update * try change snapshot * change snap * update snap * feat: remove unnecessary ts-ignore * feat: add more test cases * feat: create CodegenActions; other minor refactors * feat: continue UI work * feat: ignore config and Cypress-related files * feat: PR feedback * update Vue component link * merge in default export work * consolidate graphql queries * other misc feedback * use network-only policy to fetch files; include cypress/ dir for code gen candidates; fix type error * add basic e2e test * fix app integration tests * refactor and fix app component and webpack dev server tests * add error state; fix unit tests [skip ci] * simplify generator show logic [skip ci] * more testing * fix types * style updates [skip ci] * fix error state [skip ci] * fix list padding [skip ci] * use slots (#25079) * add more tests; fix unit tests * fix types * fix test describe * add percy snapshots for new list * update trouble rendering banner link [skip ci] * use collapsible component * use button for component list items * fix tests * build binaries * revert changes to circle config * remove eslintignore and extra loading div [skip ci] because we know it will fail * revert changes to framework glob patterns [skip ci] Co-authored-by: Ryan Manuel <ryanm@cypress.io> Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com> * feat: pass parser options to allow parsing of tsx files (#25145) * fix create from component e2e test * build binaries [run ci] * fix component tests [run ci] * regen windows snapshot Co-authored-by: Ryan Manuel <ryanm@cypress.io> Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com> Co-authored-by: Zachary Williams <ZachJW34@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
n/a (this can go in the feature branch PR)
Additional details
This PR adds the base UI for Create from React component.
Steps to test
Verify that the design matches Figma (minus the "choose a file name for this spec" which will be added with #25005)
How has the user experience changed?
https://www.loom.com/share/bfe89f3314f5441f85d5ff97b9667140
PR Tasks
cypress-documentation? Add section for create from React component cypress-documentation#4907type definitions?Outstanding Items
- [ ] Add screen to allow the user to choose spec path and nameAllow users to change spec path before it is created from component #25005