Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

width/height 0 and transform + overflow hidden #6093

Closed
sainthkh opened this issue Jan 6, 2020 · 2 comments · Fixed by #5916 · May be fixed by qsays/grafana#1
Closed

width/height 0 and transform + overflow hidden #6093

sainthkh opened this issue Jan 6, 2020 · 2 comments · Fixed by #5916 · May be fixed by qsays/grafana#1
Labels
topic: visibility 👁 type: regression A bug that didn't appear until a specific Cy version release

Comments

@sainthkh
Copy link
Contributor

sainthkh commented Jan 6, 2020

Current behavior:

When an element has width or height 0px with non-none transform and overflow hidden, it is not visible. But isHidden() cannot detect it.

<!-- Example -->
<div style="height: 0px; transform: translate(1, 2)"><p>Visible</p></div>
<div style="height: 0px; transform: translate(1, 2); overflow: hidden"><p>Invisible</p></div>

It is found with cypress-example-piechopper in https://circleci.com/gh/cypress-io/cypress-test-example-repos/71863.

Desired behavior:

isHidden() should detect it.

Steps to reproduce: (app code and test code)

  1. Download https://github.com/cypress-io/cypress-example-piechopper.
  2. Change cypress to dev version.
  3. Run app_spec.js
  4. "displays hamburger menu" fails.

Versions

After #6000 is merged.

@jennifer-shehane jennifer-shehane added topic: visibility 👁 type: regression A bug that didn't appear until a specific Cy version release labels Jan 6, 2020
@cypress-bot cypress-bot bot added stage: ready for work The issue is reproducible and in scope stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope labels Jan 6, 2020
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jan 7, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 7, 2020

The code for this is done in cypress-io/cypress#5916, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@jennifer-shehane
Copy link
Member

Released in 3.8.2

@cypress-io cypress-io locked as resolved and limited conversation to collaborators Mar 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic: visibility 👁 type: regression A bug that didn't appear until a specific Cy version release
Projects
None yet
2 participants