Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react input type email clears, not firing event #770

Closed
spearmootz opened this issue Oct 18, 2017 · 10 comments
Closed

react input type email clears, not firing event #770

spearmootz opened this issue Oct 18, 2017 · 10 comments
Assignees
Milestone

Comments

@spearmootz
Copy link

  • Operating System:
  • Cypress Version:
  • Browser Version:

Is this a Feature or Bug?

Bug

Current behavior:

Cypress not emitting event on valid or invalid email on input type email, so when you go handle user action, you dont have the values in state

Desired behavior:

events are triggered for input type email

How to reproduce:

Test code:

Additional Info (images, stack traces, etc)

@spearmootz spearmootz changed the title input type email clears, not firing event react input type email clears, not firing event Oct 18, 2017
@jennifer-shehane
Copy link
Member

What event are you specifically listening to? Are you talking about the invalid event?

Could you possibly paste some sample test code/html of what you are doing/testing?

@jennifer-shehane jennifer-shehane added the stage: needs information Not enough info to reproduce the issue label Oct 18, 2017
@spearmootz
Copy link
Author

spearmootz commented Oct 18, 2017 via email

@jennifer-shehane
Copy link
Member

What version of Cypress are you using? We just did some fixes for onChange events in version 1.0.2. #647

@spearmootz
Copy link
Author

spearmootz commented Oct 18, 2017 via email

@jennifer-shehane jennifer-shehane added stage: needs investigating Someone from Cypress needs to look at this and removed stage: needs information Not enough info to reproduce the issue labels Oct 18, 2017
@brian-mann
Copy link
Member

@chrisbreiding can you investigate this. There are already react v16 e2e tests in the driver code

@chrisbreiding chrisbreiding self-assigned this Oct 20, 2017
@Fjoggs
Copy link

Fjoggs commented Oct 21, 2017

I'm not sure if it's related, but I have issues with React 16 + cy.type only with Electron. Chrome works as expected. I made a comment on the closed issue:
#647

Maybe spearmootz is using Electron too?

@spearmootz
Copy link
Author

no im using web. im actually going to close this issue because i made a small sample test using codepen and cypress and the tests passed. so there might be something going on behind the hood of my code that im not identifying as an issue.

@Fjoggs
Copy link

Fjoggs commented Oct 25, 2017

What do you mean by web? Chrome? You can specify if you want to use Chrome or Electron when you run your tests.

@chodorowicz
Copy link

Same problem here still. Working good in Chrome, but not in headless Electron.

@brian-mann
Copy link
Member

Fixed in 1.0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants