-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(component-testing): Make cypress's folders to be transpiled by default via webpack-preprocessors #14602
feat(component-testing): Make cypress's folders to be transpiled by default via webpack-preprocessors #14602
Conversation
Thanks for taking the time to open a PR!
|
blocked by bahmutov/find-webpack#18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that make sense. Thank you 🙏
} | ||
|
||
if (config.integrationFolder) { | ||
folders.push(config.integrationFolder) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need an integration folder for component testing? Adding a new folder for compilation increases the initial build time exponentially
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the same was for cra-v3
plugin but I guess it should be fine if we exclude it
it looks like CI is failling because of PR problems, can you please take a look? |
76da596
to
797c47e
Compare
yeah, I found the problem and created fix in here bahmutov/find-webpack#19 |
Cool let's wait for @bahmutov approve and release (should be fast thanks to semantic-release) and then after CI passed |
Thanks for this! One small thing left – please sign the CLA agreement by the link inside the PR comments and it will be ok to merge |
0062ef3
to
6070dfe
Compare
6070dfe
to
65e8787
Compare
@dmtrKovalenko done |
Make sure this will be released automatically through the our 2 weeks release pipeline. Probably next Monday. |
User facing changelog
Cypress folders are added to be transpiled by webpack for react/plugins/load-webpack by default
Additional details
logic from
@cypress/react/plugins/cra-v3
reusedHow has the user experience changed?
no need to customise webpack config with cypress folders
PR Tasks