Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component-testing): Make cypress's folders to be transpiled by default via webpack-preprocessors #14602

Merged

Conversation

pashidlos
Copy link
Contributor

User facing changelog

Cypress folders are added to be transpiled by webpack for react/plugins/load-webpack by default

Additional details

logic from @cypress/react/plugins/cra-v3 reused

How has the user experience changed?

no need to customise webpack config with cypress folders

PR Tasks

  • Has the original issue or this PR been tagged with a release in ZenHub?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 16, 2021

Thanks for taking the time to open a PR!

@CLAassistant
Copy link

CLAassistant commented Jan 16, 2021

CLA assistant check
All committers have signed the CLA.

@pashidlos pashidlos changed the title react/plugins/load-webpack. Add cypress folders to be transpiled by default feat: react/plugins/load-webpack. Add cypress folders to be transpiled by default Jan 16, 2021
@pashidlos pashidlos changed the title feat: react/plugins/load-webpack. Add cypress folders to be transpiled by default feat(component-testing): react/plugins/load-webpack. Add cypress folders to be transpiled by default Jan 16, 2021
@pashidlos
Copy link
Contributor Author

blocked by bahmutov/find-webpack#18

@jennifer-shehane jennifer-shehane requested a review from a team January 19, 2021 05:47
dmtrKovalenko
dmtrKovalenko previously approved these changes Jan 19, 2021
Copy link
Contributor

@dmtrKovalenko dmtrKovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that make sense. Thank you 🙏

}

if (config.integrationFolder) {
folders.push(config.integrationFolder)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need an integration folder for component testing? Adding a new folder for compilation increases the initial build time exponentially

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same was for cra-v3 plugin but I guess it should be fine if we exclude it

@dmtrKovalenko
Copy link
Contributor

it looks like CI is failling because of PR problems, can you please take a look?

@pashidlos
Copy link
Contributor Author

@dmtrKovalenko

it looks like CI is failling because of PR problems, can you please take a look?

yeah, I found the problem and created fix in here bahmutov/find-webpack#19
could you review it as well?

@dmtrKovalenko
Copy link
Contributor

Cool let's wait for @bahmutov approve and release (should be fast thanks to semantic-release) and then after CI passed

dmtrKovalenko
dmtrKovalenko previously approved these changes Jan 29, 2021
@dmtrKovalenko dmtrKovalenko changed the title feat(component-testing): react/plugins/load-webpack. Add cypress folders to be transpiled by default feat(component-testing): Make cypress's folders to be transpiled by default via webpack-preprocessors Jan 29, 2021
@dmtrKovalenko
Copy link
Contributor

Thanks for this! One small thing left – please sign the CLA agreement by the link inside the PR comments and it will be ok to merge

@pashidlos pashidlos force-pushed the 14601-load-webpack-add-cy-folders branch from 6070dfe to 65e8787 Compare January 30, 2021 11:40
@pashidlos
Copy link
Contributor Author

@dmtrKovalenko done
needed to fix git history sign CLA agreement due to wrong author details

@dmtrKovalenko
Copy link
Contributor

Make sure this will be released automatically through the our 2 weeks release pipeline. Probably next Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cypress folders to be transpiled by webpack for react/plugins/load-webpack by default
3 participants