Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component testing): default config values #15902

Merged
merged 2 commits into from
Apr 9, 2021

Conversation

Akryum
Copy link
Contributor

@Akryum Akryum commented Apr 9, 2021

User facing changelog

Fixes the viewport 1000x660 being ignored for component testing. Fixes #15899

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 9, 2021

Thanks for taking the time to open a PR!

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021

CLA assistant check
All committers have signed the CLA.

@JessicaSachs JessicaSachs self-requested a review April 9, 2021 15:28
@JessicaSachs
Copy link
Contributor

Nice. I saw this on Saturday, too, but didn't have time to triage. Thanks for catching it and patching.

Gonna write tests for this and then merge it in.

@JessicaSachs JessicaSachs marked this pull request as ready for review April 9, 2021 16:27
@JessicaSachs JessicaSachs requested a review from a team as a code owner April 9, 2021 16:28
Copy link
Contributor

@JessicaSachs JessicaSachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again for the patch. We have system tests going in within the next week that'll cover this and catch the hacks we put in (like this one).

CI is failing, but the 2 jobs are unrelated to your changes, so don't worry about it.

@JessicaSachs JessicaSachs merged commit a5bb2e0 into cypress-io:develop Apr 9, 2021
@Akryum Akryum deleted the fix-ct-viewport-size branch April 9, 2021 19:35
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 12, 2021

Released in 7.1.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.1.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component testing] Viewport size config ignored if 1000x660
3 participants