Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BREAKING): Set DPR to 1 for Chrome headless browsers by default #17377

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

jennifer-shehane
Copy link
Member

User facing changelog

  • When running —headless Chromium based browsers via cypress run, the device pixel ratio will now be 1 by default, matching the behavior of all other browsers. This behavior can be overridden through the browser launch API [link to instructions on how to change this].

Additional Details

  • This didn’t end up being as difficult as first suspected because it turns out Chrome is the only browser that is using the DPR of the machine it’s run in instead of just 1x.

User Experience

  • People who were running in 2x machines (like a Mac retina) will see the resolution of their screenshots and videos reduced. This can be overridden.

@jennifer-shehane jennifer-shehane requested a review from a team as a code owner July 16, 2021 20:27
@jennifer-shehane jennifer-shehane requested review from flotwig and kuceb and removed request for a team July 16, 2021 20:27
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 16, 2021

Thanks for taking the time to open a PR!

@jennifer-shehane jennifer-shehane self-assigned this Jul 16, 2021
@jennifer-shehane jennifer-shehane added the type: breaking change Requires a new major release version label Jul 16, 2021
@jennifer-shehane jennifer-shehane changed the base branch from develop to 8.0-release July 16, 2021 20:28
@jennifer-shehane jennifer-shehane changed the title feat[BREAKING]: Set DPR to 1 for Chrome headless browsers by default feat(BREAKING): Set DPR to 1 for Chrome headless browsers by default Jul 16, 2021
@cypress
Copy link

cypress bot commented Jul 16, 2021



Test summary

4131 0 53 1Flakiness 2


Run details

Project cypress
Status Passed
Commit 9b8c676
Started Jul 16, 2021 9:03 PM
Ended Jul 16, 2021 9:13 PM
Duration 10:27 💡
OS Linux Debian - 10.9
Browser Firefox 89

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/commands/net_stubbing_spec.ts Flakiness
1 network stubbing > intercepting request > can intercept utf-8 request bodies without crashing
2 ... > automatically parses application/json response bodies

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: breaking change Requires a new major release version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set screen's device pixel ratio to a standard ratio for all browsers run headlessly via cypress run
2 participants