-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Error message for cy.select() with no arguments #18234
Conversation
…s-io/cypress into issue-757-select-by-index
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
Thanks for taking the time to open a PR!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does fix the issue. Nice.
This PR includes the files changes from the other feature though, adding the index
feature. Can you have this PR only reflect the changes necessary for the error message when cy.select()
has no arguments?
If the PRs are dependent on each other, we could work on getting one in before the other. I see how the error message is a bit affected by the other PR.
@jennifer-shehane This should be updated now, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! 💯
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
User facing changelog
We include a more useful error message when
.select()
is incorrectly called with no arguments.Additional details
Previous message: "Cannot read properties of undefined, (reading 'replace')"
New message: "
cy.select()
was not called with any value, index, or text"PR Tasks