fix: Exit when both --e2e and --component flags are passed in #18855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlueWinds
requested review from
jennifer-shehane
and removed request for
a team
|
Thanks for taking the time to open a PR!
|
BlueWinds
changed the title
BlueWinds
commented
Nov 9, 2021
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
cli/lib/util.js
Outdated
| @@ -241,6 +241,14 @@ const parseOpts = (opts) => { | |||
|
|
|||
| debug('parsed cli options %o', cleanOpts) | |||
|
|
|||
| if (cleanOpts.component && cleanOpts.e2e) { | |||
There was a problem hiding this comment.
Can we move the error text to https://github.com/cypress-io/cypress/blob/develop/cli/lib/errors.js?
There was a problem hiding this comment.
Done.
I had not realized exactly how many different ways we have to throw errors in the command line. It might be a worthwhile project to examine and consider unifying at some point.
jennifer-shehane
approved these changes
Nov 9, 2021
emilyrohrbough
approved these changes
Nov 10, 2021
tgriesser
added a commit
that referenced
this pull request
Nov 17, 2021
* 10.0-release: feat: improve vite DX (#18937) feat: Use plugins on config files (#18798) BREAKING CHANGE: trigger major bump BREAKING CHANGE: trigger major bump fix: fix cypress/package.json crasher fix(breaking): change circle.yml to release binary fix: build-prod-ui deps before build-prod packages feat: implement spec list tree (#18901) chore: adding 10.0-release to the circle.yml build script (#18926) feat(app): remove __vite__ route and default to unified runner (#18909) fix: app layout + specs list review (#18862) feat(app): show previous versions (#18838) feat: scaffold integration files in app (#18763) feat: add footer to the settings (#18867) fix: Exit when both --e2e and --component flags are passed in (#18855)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
When incompatible flags are passed in, we exit rather than assuming which the user preferred.
cypress open --e2e --componentand
cypress run --e2e --componentare both now errors and exit immediately.
How has the user experience changed?
Previously, we would assume end-to-end, and run/open cypress in that mode. Now, we exit with an error:
PR Tasks