fix: flaky redirect test #19042
Merged
fix: flaky redirect test #19042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjhenkes
requested review from
jennifer-shehane
and removed request for
a team
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||
chrisbreiding
requested review from
chrisbreiding and
flotwig
and removed request for
jennifer-shehane
chrisbreiding
approved these changes
Nov 23, 2021
flotwig
approved these changes
Nov 23, 2021
Comment on lines
+46
to
+53
| app.get('/redirect-timeout', (req, res) => { | ||
| return Promise | ||
| .delay(100) | ||
| .then(() => { | ||
| return res.send('<html><body>timeout</body></html>') | ||
| }) | ||
| }) | ||
|
|
There was a problem hiding this comment.
nit: is there something blocking you from creating a cy.intercept() instead of a new route in server.js? This file be balloonin'. I guess you'd have to update the test to deal with the add'l logs.
There was a problem hiding this comment.
Yeah, this was my attempt to be minimally invasive.
tgriesser
added a commit
that referenced
this pull request
Nov 28, 2021
* develop: test: node_modules installs for system-tests, other improvements (#18574) chore(deps): update dependency semantic-release to v17.2.3 [security] (#19022) chore: remove flaky ci jobs for main builds (#19071) chore(contributing): clarify PULL_REQUEST_TEMPLATE (#19068) fix: the shadow root container element is ignored when clicking an element in it. (#18908) 'Fix' flaky redirect test (#19042) release 9.1.0 [skip ci] fix: Allow 'this' to be used in overridden commands (#18899) fix(react): link to rerender example (#19020) chore(deps): update dependency aws-sdk to v2.814.0 [security] (#18948) fix: test config overrides leak for .only execution (#18961) feat: Set CYPRESS=true as env var in child processes where Cypress runs user code in Node (#18981) fix: Restore broken gif (#18987) chore: release @cypress/vite-dev-server-v2.2.1
lmiller1990
pushed a commit
that referenced
this pull request
Nov 29, 2021
tgriesser
added a commit
that referenced
this pull request
Nov 29, 2021
* 10.0-release: feat(graphql): ability to update/query for appData (#19082) fix system test fix failing tests due to merge resolve conflicts test: node_modules installs for system-tests, other improvements (#18574) update yarn.lock chore(deps): update dependency semantic-release to v17.2.3 [security] (#19022) chore: remove flaky ci jobs for main builds (#19071) chore(contributing): clarify PULL_REQUEST_TEMPLATE (#19068) fix: the shadow root container element is ignored when clicking an element in it. (#18908) 'Fix' flaky redirect test (#19042) release 9.1.0 [skip ci] fix: Allow 'this' to be used in overridden commands (#18899) fix(react): link to rerender example (#19020) chore(deps): update dependency aws-sdk to v2.814.0 [security] (#18948) fix: test config overrides leak for .only execution (#18961) feat: Set CYPRESS=true as env var in child processes where Cypress runs user code in Node (#18981) fix: Restore broken gif (#18987) chore: release @cypress/vite-dev-server-v2.2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Change is not user facing.
Additional details
This test is failing due to issue #19039. Previously failed XHR calls can be matched up with subsequent XHR calls inappropriately. Specifically the
/timeout?ms=100call is matching up with a previously failed instance of this. This pr avoids this issue by specifying a new/retry-timeoutroute. Since the route is unique to this test it doesn't have the possibility of having a previously failed pre-request. This is not fixing the root issue, just providing flaky test relief.How has the user experience changed?
PR Tasks