fix(deps): update dependency graceful-fs to v4.2.9 🌟

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
graceful-fs	4.2.0 -> 4.2.9

---

Release Notes

isaacs/node-graceful-fs

v4.2.9

Compare Source

v4.2.8

Compare Source

v4.2.7

Compare Source

v4.2.6

Compare Source

v4.2.5

Compare Source

v4.2.4

Compare Source

v4.2.3

Compare Source

v4.2.2

Compare Source

v4.2.1

Compare Source

---

Configuration

📅 Schedule: "before 3am on the first day of the month" in timezone America/New_York.

🚦 Automerge: Enabled.

♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by WhiteSource Renovate. View repository job log here.

[cypress-bot]

See the guidelines for reviewing dependency updates for info on how to review dependency update PRs.

[cypress]

---

Test summary

19129 • 0 • 218 • 0 • 1

---

Run details

Project	cypress
Status	Passed
Commit	92d4590
Started	Jan 17, 2022 4:25 PM
Ended	Jan 17, 2022 4:36 PM
Duration	11:24 💡
OS	Linux Debian - 10.10
Browser	Multiple

View run in Cypress Dashboard ➡️

---

Flakiness

	cypress/integration/cypress/proxy-logging_spec.ts		1
1	Proxy Logging > request logging > xhr log has response body/status code

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[mjhenkes]

Ok, so this change breaks yarn 2 support more than it already is.

Currently using yarn version 2.4.3 cypress open fails due to graceful-fs (version 4.2.0) See issue #6377, specifically my last comment.
However, cypress run still works and thus the tests pass

By upgrading to graceful-fs (version 4.2.9) both cypress open and run fail with:

glob error TypeError: Cannot destructure property 'withFileTypes' of '(intermediate value)(intermediate value)(intermediate value)' as it is null.
    at PosixFS.readdirPromise (/Users/matthenkes/Source/cypress-test-repo/.pnp.js:12043:5)
    at /Users/matthenkes/Source/cypress-test-repo/.pnp.js:15069:20
    at processTicksAndRejections (node:internal/process/task_queues:78:11)

TypeError: Cannot destructure property 'withFileTypes' of '(intermediate value)(intermediate value)(intermediate value)' as it is null.
    at PosixFS.readdirPromise (/Users/matthenkes/Source/cypress-test-repo/.pnp.js:12043:5)
    at /Users/matthenkes/Source/cypress-test-repo/.pnp.js:15069:20
    at processTicksAndRejections (node:internal/process/task_queues:78:11)

TypeError: Cannot destructure property 'withFileTypes' of '(intermediate value)(intermediate value)(intermediate value)' as it is null.
    at PosixFS.readdirPromise (/Users/matthenkes/Source/cypress-test-repo/.pnp.js:12043:5)
    at /Users/matthenkes/Source/cypress-test-repo/.pnp.js:15069:20
    at processTicksAndRejections (node:internal/process/task_queues:78:11)

This appears to be a yarn bug that was fixed with version 3.

Both cypress open and run work with yarn 3.1.1.

So we need to decided if we support want to try to support yarn 2, if not we can upgrade the test to instead use yarn 3.

[mjhenkes]

I'm going to restate the graceful-fs problem here:

Graceful-fs v4.2.0 - 4.2.8 breaks when used in conjunction with resolve v1.21¹. This surfaced in cypress when trying to run component tests with vite².

When used with Yarn v2.4.3 Cypress open mode fails with an error³.
TypeError: BigInt.prototype.toString requires that 'this' be a BigInt.
Cypress run mode executes. I'm not sure if this is a yarn bug, but it occurs when graceful-fs v4.2.0 is present.

When Graceful-fs is updated to v4.2.9, using yarn v2.4.3 Both Cypress run and Open fail with the following error:

glob error TypeError: Cannot destructure property 'withFileTypes' of '(intermediate value)(intermediate value)(intermediate value)' as it is null.
    at PosixFS.readdirPromise (/Users/matthenkes/Source/cypress-test-repo/.pnp.js:12043:5)
    at /Users/matthenkes/Source/cypress-test-repo/.pnp.js:15069:20
    at processTicksAndRejections (node:internal/process/task_queues:78:11)

TypeError: Cannot destructure property 'withFileTypes' of '(intermediate value)(intermediate value)(intermediate value)' as it is null.
    at PosixFS.readdirPromise (/Users/matthenkes/Source/cypress-test-repo/.pnp.js:12043:5)
    at /Users/matthenkes/Source/cypress-test-repo/.pnp.js:15069:20
    at processTicksAndRejections (node:internal/process/task_queues:78:11)

TypeError: Cannot destructure property 'withFileTypes' of '(intermediate value)(intermediate value)(intermediate value)' as it is null.
    at PosixFS.readdirPromise (/Users/matthenkes/Source/cypress-test-repo/.pnp.js:12043:5)
    at /Users/matthenkes/Source/cypress-test-repo/.pnp.js:15069:20
    at processTicksAndRejections (node:internal/process/task_queues:78:11)

This is a yarn bug that was corrected in yarn version 3⁴. Both cypress open and cypress run work with yarn v3. (Tested with yarn v3.1.1).

Cypress bundles graceful-fs with it's electron app and uses it when executing user tests/plugins. So any kind of yarn resolution won't help in this case.⁵⁶

Options:

• Do nothing and leave vite broken and yarn v2 with partial support (run only).
• Update to Graceful-fs 4.2.9, and support yarn v3 and above. I'm unsure what the burden is on developers to update to yarn 3⁷, but these do seem like yarn 2 bugs. The yarn 2 system test would have to be updated to use yarn 3 with this PR.
• Maintain Yarn v2.4.3 support.
  • Remove Graceful-fs and handle EMFILE error from too many file descriptors ourselves.
  • Patch Graceful-fs v4.2.0 with the v4.2.9 fix⁸
  • Patch Graceful-fs v4.2.9 to avoid the Yarn 2 bug, if possible.

Removing Graceful-fs or patching it would require more spiking to determine viability and would obviously be more expensive. This issue will also present in cypress v10 without intervention.

Footnotes

1. https://github.com/browserify/resolve/issues/264 ↩

2. https://github.com/cypress-io/cypress/issues/19610 ↩

3. https://github.com/cypress-io/cypress/issues/6377#issuecomment-1011513982 ↩

4. https://github.com/yarnpkg/berry/issues/3234 ↩

5. https://github.com/cypress-io/cypress/blob/develop/packages/server/lib/plugins/child/index.js#L1 ↩

6. https://github.com/cypress-io/cypress/blob/develop/packages/server/lib/util/require_async_child.js#L1 ↩

7. https://dev.to/arcanis/yarn-3-0-performances-esbuild-better-patches-e07 ↩

8. https://github.com/isaacs/node-graceful-fs/pull/220 ↩

[ljharb]

if yarn 2 is EOL and fixes won't be backported to it, what's the point of trying to support it?

.

[emilyrohrbough]

I vote moving forward with Yarn 3 support and fixing the vite issue. We can make a note we have limited yarn 2 support and don't recommend using Cypress with Yarn 2.

[cypress-bot]

Released in 9.3.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v9.3.0, please open a new issue.