test(system-tests): support npm for test projects #20664
Conversation
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||
…t always symlinked
flotwig
force-pushed
the
refactor-dep-installer
branch
from
2b1b07e to
360d8b7
Compare
flotwig
requested review from
jennifer-shehane
and removed request for
a team and
jennifer-shehane
| @@ -38,4 +38,6 @@ | |||
| // Volar is the main extension that powers Vue's language features. | |||
| // "volar.autoCompleteRefs": false, | |||
| "volar.takeOverMode.enabled": true, | |||
|
|
|||
| "editor.tabSize": 2, | |||
There was a problem hiding this comment.
not necessarily related to this PR, but I noticed sometimes vscode doesn't know what our tab size is (where does that even come from? eslint?) and will default to 4.
| } | ||
| } | ||
|
|
||
| export async function scaffoldCommonNodeModules () { |
There was a problem hiding this comment.
Can you add a comment above this line describing what it does?
| optionalDependencies?: Dependencies | ||
| } | ||
|
|
||
| const log = (...args) => console.log('📦', ...args) |
There was a problem hiding this comment.
Nitpicking here, but a fun TS trick to get the correct type of ...args:
const log = (...args: Parameters<typeof console.log>) => console.log('📦', ...args)There was a problem hiding this comment.
Nice, thanks for the tip. I think I'll leave this one as-is since it's so simple and we use this pattern elsewhere but I'll keep Parameters in mind.
| await symlinkNodeModulesFromCache(tmpNodeModulesDir, cacheNodeModulesDir) | ||
| } else { | ||
| // due to an issue in NPM, we cannot have `node_modules` be a symlink. fall back to copying. | ||
| // https://github.com/npm/npm/issues/10013 |
There was a problem hiding this comment.
Seems the linked issue is 3-4 years old - I wonder if/when this will be fixed, or if it's a wontfix. 😢
There was a problem hiding this comment.
Yeah, I'm not sure, I unfortunately wasn't able to find a corresponding issue in their un-archived repo. But it's definitely still an issue.
| await fs.symlink(targetDir, destDir, 'junction') | ||
| } | ||
|
|
||
| // 8. If necessary, ensure that the `node_modules` cache is updated by copying `node_modules` back. |
There was a problem hiding this comment.
Big 👍 to the comments here
User facing changelog
n/a
Additional details
Actual diff minus lockfile changes is +400 -283
yarn: test: node_modules installs for system-tests, other improvements #18574npm.npmas well ifpackage-lock.jsonis detected.vite-ctproject has been converted to usingnpmto prove that this works.fixtures.ts, it has been moved to adep-installersubfolderHow has the user experience changed?
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?