chore: moving over many vue + vite system tests to use object API instead of function API #21080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
9 tasks
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||||||||||
…ount' into chore/cutover-to-bundled-vue-mount
…ount' into chore/cutover-to-bundled-vue-mount
…ount' into chore/cutover-to-bundled-vue-mount
…ss-io/cypress into chore/cutover-to-bundled-vue-mount
lmiller1990
requested review from
jennifer-shehane
and removed request for
a team
|
Fixed these guys, gonna merge into the feat branch @JessicaSachs. |
lmiller1990
added a commit
that referenced
this pull request
Apr 20, 2022
… API (#21079) * removing vite-dev-server local dependency from react-vite-ts-configured system test * moving some CRA examples over to use the object api for setup * fixing issue where function API was broken by object API for cy config + devservers * adding deeply nested react import to project-fixtures for cra * finishes cutting over cypress/react for sys tests * chore: adding circle for this feature branch * chore: moving over many vue + vite system tests to use object API instead of function API (#21080) * doing webpack-dev-server cutovers * removing more webpack-dev-server refrences * fixing snapshots * bumping yarn.lock * wip * fix test * fix assertion Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com> * feat: removing all references for "fresh" dev servers (webpack-dev-server-fresh and vite-dev-server-fresh) (#21094) Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com> Co-authored-by: Zachary Williams <ZachJW34@gmail.com> * chore: add dev-servers as deps to server to be included in the binary (#21091) * fix bad merge * fix next types and webpack-dev-server- resolve Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com> Co-authored-by: Zachary Williams <ZachJW34@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the parent Pull Request #21079 for the latest details.