-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: running a new test after already having run tests #21087
Merged
lmiller1990
merged 13 commits into
10.0-release
from
ryanm/fix/running-new-test-after-already-running-test
Apr 19, 2022
Merged
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9d4ab60
fix: running a new test after already having run tests
ryanthemanuel fc98d53
Blank commit
tbiethman 3deea27
Merge branch '10.0-release' into ryanm/fix/running-new-test-after-alr…
ryanthemanuel 0bfcee9
Add test for scenario
ryanthemanuel 68b41cb
Refactor
ryanthemanuel 02266c8
Further refactoring. Needs to be a watchEffect rather than watch
ryanthemanuel 42a3e0b
Fix tests
ryanthemanuel 1f74408
Fix tests
ryanthemanuel 8941c26
Fix flake
ryanthemanuel 8e2095f
Merge branch '10.0-release' into ryanm/fix/running-new-test-after-alr…
ryanthemanuel 238ca80
Merge branch '10.0-release' into ryanm/fix/running-new-test-after-alr…
ryanthemanuel 98c813d
PR comments
ryanthemanuel 1961541
Fix flake with event manager and active spec
ryanthemanuel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a strong opinion but I like to functions that call
watch
orwatchEffect
in the actual component file to give visibility, or you need to dig through a bunch of other files to find the watcher. It's like when you are trying to track down auseState
oruseEffect
nested deeply in a hook in React.I don't mind too much, but something about
watchSpec(specs)
is more readable to me thanuseUnifiedRunner(specs)
. The former is more clear that something reactive will happen. Happy to field opinions and not really a big deal either way.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer adding 'watcher' to the composable's name in some way if more discoverability is desired. Putting the responsibility of activating the watchers on the consuming component just leaves a logic hole where there doesn't need to be one.