fix: label text should be clickable to toggle snapshot highlight #21122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Now that the label is clickable, whaddya think about adding |
|
@rachelruderman good point. On a general form field it seems like too much, but here I can see it making it easier for users to discover how it works and not having to be so precise. |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
lmiller1990
approved these changes
Apr 19, 2022
|
Nice, this has been a pain point for me for a while. Thanks for following up on this. |
|
@rachelruderman done! |
rachelruderman
approved these changes
Apr 19, 2022
tgriesser
added a commit
that referenced
this pull request
Apr 20, 2022
…e-config * 10.0-release: chore: Move component-index generation to scaffold-config package (#21090) fix: label text should be clickable to toggle snapshot highlight (#21122) feat: add next preset to webpack-dev-server-fresh (#21069) chore: add dev-servers as deps to server to be included in the binary (#21142) fix: do not highlight preExtension if selected option is renameFolder (#21121) fix(unify): Remove 'Reconfigure' dropdown from Testing Type chooser (#21063) feat(unify): launchpad header breadcrumbs and reusable tooltip component (#20648) test: add windows-test-kitchensink job (#20847) fix: aut centering and height calculation (#21019) chore: fix tests that fail on windows (#21055) fix: running a new test after already having run tests (#21087) fix: ct project setup framework keys for next and nuxt (#21116) fix: remove MountReturn from scaffolded ct support file (#21119) fix: do not scaffold fixtures if folder exist (#21078) fix: revert "fix: types for Cypress.Commands.add (#20376)" (#21104) chore: Update Chrome (stable) to 100.0.4896.127 and Chrome (beta) to 101.0.4951.34 (#21083) fix: types for Cypress.Commands.add (#20376) (#20377)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Fixes switch label to be clickable, not just the switch itself. Switch is also labelled correctly in the Accessibility Tree after this PR. @lmiller1990 noticed this in a PR review on a related part of the code, but it was merged before this could be updated.
Additional details
Updated test to use
cy.findByLabelText(highlightsLabel)instead ofcy.get('[id="toggle-highlights"]')to catch regressions.How has the user experience changed?
Previously, text was not clickable to active the switch:
current.mov
Now, it is:
desired.mov
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?