feat: IATR non-failure run statuses #25286

astone123 · 2022-12-27T22:54:21Z

Closes [IATR](M1.0) Non-failure Run Statuses #24848

User facing changelog

n/a, merging to a feature branch

Additional details

For some run statuses on the Debug tab, we need to display specific information, sometimes in addition to displaying the failing tests for debugging. This PR adds UI for the following run states:

CANCELLED
PASSED
ERRORED
NOTESTS
TIMEDOUT
OVERLIMIT

Steps to test

Ideally, you should create a run on your local Cloud instance for each of the statuses listed above. I was only able to actually re-create a few of them end to end (I couldn't re-create TIMEDOUT or OVERLIMIT). I would suggest checking out the tests that I added here and viewing the Percy snapshots that were generated from those tests and comparing those to the Figma.

There's an issue with the tests for PASSED and OVERLIMIT where in the test they appear towards the top of the viewport instead of further down where they should be. However, if you actually view these states on the Debug tab, they show up correctly. There should be a flex-grow class on these that create the correct height for the elements but it's not working in the tests.

How has the user experience changed?

See Percy diff

PR Tasks

Have tests been added/updated?
[na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
[na] Has a PR for user-facing changes been opened in cypress-documentation?
[na] Have API changes been updated in the type definitions?

…24848-non-failure-run-statuses

cypress-bot · 2022-12-27T22:54:23Z

Thanks for taking the time to open a PR!

Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

packages/app/src/debug/DebugPageDetails.vue

astone123 · 2022-12-27T22:58:33Z

packages/app/src/debug/DebugPageDetails.vue

+<template>
+  <div
+    class="flex flex-col w-full px-24px justify-center items-center align-middle"
+    :class="{'flex-grow': ['PASSED', 'OVERLIMIT'].includes(status)}"


This class doesn't seem to do anything in the tests, but it does in the actual debug tab view 🤷🏻‍♂️

astone123 · 2022-12-27T23:00:34Z

packages/app/src/debug/DebugPageDetails.vue

+const props = defineProps<{
+  status: CloudRunStatus
+  canceledAt: string | null
+  canceledByFullName?: string | null


If anyone has tips on how to deal with this, I'd be happy to refactor. I guess when something is nullable in GQL, it can be either TheType | undefined | null? This leads to weird stuff with TypeScript where it's not enough to just make the prop optional, you also have to specify that it could be null. It's ugly

I spiked into fixing this but it's going to be a chunk of work. There's a bunch of options we can configure: https://the-guild.dev/graphql/codegen/plugins/typescript/typescript-operations

The ones we need to figure out and standardize:

maybeValue (default is T | null, maybe we want undefined?)

we should do immutableTypes: false. This will stop generating readonly which is a bit annoying, even if it's more technically correct

An alternative in the short term might be type Maybe<T> = T | undefined | null. 🤷‍♂️

packages/app/src/debug/DebugCancelledAlert.vue

cypress · 2022-12-27T23:14:29Z

Test summary

26454 • 0 • 1180 • 0 • 29

Run details


Project	cypress
Status	Passed
Commit	`0bf96fe`
Started	Dec 29, 2022 4:12 AM
Ended	Dec 29, 2022 4:32 AM
Duration	19:24 💡
OS	Linux Debian -
Browser	Multiple

View run in Cypress Dashboard ➡️

Flakiness

	create-from-component.cy.ts	2
1	... > runs generated spec
2	... > runs generated spec
	commands/net_stubbing.cy.ts	3
1	network stubbing > intercepting request > can delay and throttle a StaticResponse
2	network stubbing > intercepting request > can delay and throttle a StaticResponse
3	... > with `times` > only uses each handler N times
This comment includes only the first 5 flaky tests. See all 29 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

lmiller1990

Some comments/questions.

packages/app/src/debug/DebugCancelledAlert.vue

packages/app/src/debug/DebugContainer.vue

packages/app/src/debug/DebugPageDetails.vue

packages/graphql/test/stubCloudTypes.ts

mike-plummer

Lots of little comments/questions. Looks good for the most part, just small cleanup items

packages/app/src/debug/DebugCancelledAlert.vue

packages/app/src/debug/DebugContainer.vue

packages/app/src/debug/DebugTimedout.vue

packages/app/src/runs/utils/day.js

packages/frontend-shared/src/locales/en-US.json

lmiller1990

Please see my comment on timezones, I think getting the correct is critical.

packages/app/src/debug/DebugCancelledAlert.vue

lmiller1990

My comments have been addressed

mike-plummer

LGTM, thanks for addressing my comments 👍

rockindahizzy and others added 4 commits December 21, 2022 22:39

feat: Add details for run status in debug tab

623449d

Merge branch 'feature/IATR-M0' of github.com:cypress-io/cypress into …

be46f28

…24848-non-failure-run-statuses

Merge branch 'feature/IATR-M0' of github.com:cypress-io/cypress into …

9437430

…24848-non-failure-run-statuses

finish up error states [run ci]

e94442e

astone123 self-assigned this Dec 27, 2022

astone123 commented Dec 27, 2022

View reviewed changes

packages/app/src/debug/DebugPageDetails.vue Outdated Show resolved Hide resolved

astone123 commented Dec 27, 2022

View reviewed changes

astone123 requested review from warrensplayer, ZachJW34, lmiller1990, amehta265 and mike-plummer December 27, 2022 23:01

astone123 commented Dec 27, 2022

View reviewed changes

packages/app/src/debug/DebugCancelledAlert.vue Outdated Show resolved Hide resolved

lmiller1990 reviewed Dec 28, 2022

View reviewed changes

astone123 requested a review from marktnoonan December 28, 2022 15:04

astone123 added 2 commits December 28, 2022 11:43

feedback

c70b9f2

fix types

9b921fe

astone123 requested a review from lmiller1990 December 28, 2022 17:15

mike-plummer reviewed Dec 28, 2022

View reviewed changes

more feedback

9ee2bcc

astone123 requested a review from mike-plummer December 28, 2022 23:12

lmiller1990 reviewed Dec 28, 2022

View reviewed changes

packages/app/src/debug/DebugCancelledAlert.vue Outdated Show resolved Hide resolved

display local time rather than UTC

0bf96fe

astone123 requested a review from lmiller1990 December 29, 2022 04:01

lmiller1990 approved these changes Dec 29, 2022

View reviewed changes

mike-plummer approved these changes Dec 29, 2022

View reviewed changes

astone123 merged commit bad5093 into feature/IATR-M0 Dec 29, 2022

astone123 deleted the 24848-non-failure-run-statuses branch December 29, 2022 17:47

cypress-bot bot mentioned this pull request Dec 29, 2022

[IATR](M1.0) Non-failure Run Statuses #24848

Closed

warrensplayer mentioned this pull request Jan 5, 2023

[IATR] E2E Tests for IATR #25351

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: IATR non-failure run statuses #25286

feat: IATR non-failure run statuses #25286

astone123 commented Dec 27, 2022

cypress-bot bot commented Dec 27, 2022

astone123 Dec 27, 2022

astone123 Dec 27, 2022

lmiller1990 Dec 28, 2022

cypress bot commented Dec 27, 2022 •

edited

Loading

lmiller1990 left a comment

mike-plummer left a comment

lmiller1990 left a comment

lmiller1990 left a comment

mike-plummer left a comment

feat: IATR non-failure run statuses #25286

feat: IATR non-failure run statuses #25286

Conversation

astone123 commented Dec 27, 2022

User facing changelog

Additional details

Steps to test

How has the user experience changed?

PR Tasks

cypress-bot bot commented Dec 27, 2022

astone123 Dec 27, 2022

Choose a reason for hiding this comment

astone123 Dec 27, 2022

Choose a reason for hiding this comment

lmiller1990 Dec 28, 2022

Choose a reason for hiding this comment

cypress bot commented Dec 27, 2022 • edited Loading

Test summary

Run details

Flakiness

lmiller1990 left a comment

Choose a reason for hiding this comment

mike-plummer left a comment

Choose a reason for hiding this comment

lmiller1990 left a comment

Choose a reason for hiding this comment

lmiller1990 left a comment

Choose a reason for hiding this comment

mike-plummer left a comment

Choose a reason for hiding this comment

cypress bot commented Dec 27, 2022 •

edited

Loading