Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Debug failed test limit (#25418) #25434

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

mike-plummer
Copy link
Contributor

User facing changelog

No changelog entry, part of IATR feature

Additional details

  • Restricting gql query to pull back max of 100 failed tests to guard against very large suites with lots of failing tests
  • Adding new info banner to inform user to 100 test limit being exceeded

Steps to test

Component tests have been updated, easiest way to test is to work with mock data in those

How has the user experience changed?

New Banner
Screen Shot 2023-01-11 at 9 36 35 AM

New Banner (narrow viewport)
Screen Shot 2023-01-11 at 9 36 46 AM

New Banner (no cloud run url available)
Screen Shot 2023-01-11 at 9 36 55 AM

New banner being displayed in DebugContainer (note mocked data so test count does not actually match here)
Screen Shot 2023-01-11 at 9 39 21 AM

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

* Restrict gql query results
* Add new banner to inform user of limit being reached
@mike-plummer mike-plummer requested a review from a team January 11, 2023 15:46
@cypress
Copy link

cypress bot commented Jan 11, 2023



Test summary

5220 0 108 0Flakiness 2


Run details

Project cypress
Status Passed
Commit bf5fb2c
Started Jan 12, 2023 2:04 PM
Ended Jan 12, 2023 2:16 PM
Duration 12:07 💡
OS Linux Debian -
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/net_stubbing.cy.ts Flakiness
1 network stubbing > intercepting request > can delay and throttle a StaticResponse
e2e/origin/commands/waiting.cy.ts Flakiness
1 cy.origin waiting > alias > waits for the route alias to have a response

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@rockindahizzy rockindahizzy self-requested a review January 11, 2023 19:52
Copy link
Contributor

@rockindahizzy rockindahizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as expected!

@mike-plummer mike-plummer requested a review from a team January 11, 2023 21:21
@rockindahizzy rockindahizzy requested a review from a team January 11, 2023 21:29
Copy link
Contributor

@warrensplayer warrensplayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@warrensplayer warrensplayer merged commit 36a6eea into feature/IATR-M0 Jan 12, 2023
@warrensplayer warrensplayer deleted the mikep/25418-failed-test-limit branch January 12, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants