Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wiring up test filters to the Debug page back end #25492

Merged
merged 4 commits into from
Jan 18, 2023

Conversation

warrensplayer
Copy link
Contributor

@warrensplayer warrensplayer commented Jan 18, 2023

User facing changelog

n/a - merging to feature branch

Additional details

When completing the test filtering for the new Debug page in the PR #25265, the backend was stubbed out with test data while the remainder of the work for the cloud integration was being done here: #25316

This PR ties the work from these previous two PRs to enable the test filtering to work for each relevant run used in the new Debug page.

Steps to test

  • Record a run for a Cloud connected project into Staging or Production.
  • Open the Cypress App for that project and go to the Debug page.
  • Note the failed tests for one spec
  • Click on the "Run Failures" button for that spec
  • You should be taken to the runner and only the failed tests for that Spec should run
  • Select the "X" in the badge in the header where it says "X of Y tests"
  • This should remove that badge and run all the tests for that spec
  • Repeat with other failed specs from the Debug page to verify only the failed tests are run.

How has the user experience changed?

UI has not changed from the original PR.

PR Tasks

  • Have tests been added/updated?
  • [ n/a] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [n/a] Has a PR for user-facing changes been opened in cypress-documentation?
  • [n/a] Have API changes been updated in the type definitions?

@cypress
Copy link

cypress bot commented Jan 18, 2023



Test summary

26538 0 1180 0Flakiness 47


Run details

Project cypress
Status Passed
Commit 350111b
Started Jan 18, 2023 3:15 AM
Ended Jan 18, 2023 3:34 AM
Duration 19:07 💡
OS Linux Debian -
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

create-from-component.cy.ts Flakiness
1 ... > runs generated spec
commands/net_stubbing.cy.ts Flakiness
1 network stubbing > intercepting request > can delay and throttle a StaticResponse
2 ... > with `times` > only uses each handler N times
3 ... > stops waiting when an xhr request is canceled
4 network stubbing > intercepting request > can delay and throttle a StaticResponse
This comment includes only the first 5 flaky tests. See all 47 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@warrensplayer warrensplayer marked this pull request as ready for review January 18, 2023 03:04
@warrensplayer warrensplayer requested a review from a team January 18, 2023 03:04
@lmiller1990
Copy link
Contributor

lmiller1990 commented Jan 18, 2023

My branch w/ failure: #25475

image

It worked!

image

I feel silly but how come I don't see this same info reflected in the main page? What branch does this use again? I'm probably forgetting how this works, but it's confusing (and unrelated to this PR):

image

Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I tried it out, it works 🆗

@warrensplayer
Copy link
Contributor Author

@lmiller1990 Can you share a bit more about your comment here: #25492 (comment)

I feel silly but how come I don't see this same info reflected in the main page? What branch does this use again? I'm probably forgetting how this works, but it's confusing (and unrelated to this PR):

Are you asking why the information on the Debug page is not viewable on the Specs List page?

@warrensplayer warrensplayer merged commit 2a40aee into feature/IATR-M0 Jan 18, 2023
@warrensplayer warrensplayer deleted the stokes/25487_test_filter_query branch January 18, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants