fix: update query names for better logging #25514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warrensplayer
changed the title
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
tbiethman
reviewed
Jan 19, 2023
| @@ -10,7 +10,7 @@ import { Poller } from '../polling' | |||
| const debug = debugLib('cypress:data-context:sources:RelevantRunsDataSource') | |||
|
|
|||
| const RELEVANT_RUN_OPERATION_DOC = gql` | |||
| query RelevantRunsDataSource_latestRunUpdateSpecData( | |||
| query RelevantRunsDataSource_RunsByCommitShas( | |||
tbiethman
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
n/a
Additional details
The GQL query names for the new relevant run datasources had copy/paste names for the query names. This made the analytics tracking in Honeycomb confusing because different queries had the same name, that was also poorly named. This update gives each query a unique name that matches up with the datasource and operation it represents.
This PR also updates the logic for calculating the spec counts shown when a run is RUNNING in the cloud. The new logic sums up the groupIds for each spec to count them individually.
Steps to test
Use the App to access the Debug page against production Cloud.
Check the logging in honeycomb to confirm that the new GQL query names are being logged
How has the user experience changed?
n/a
PR Tasks
cypress-documentation?type definitions?