fix: Ensure orphaned browser instance is killed before connecting to a new one #25898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 flaky tests on run #44328 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||||||||
| Test | ||
|---|---|---|
| network stubbing > intercepting request > can delay and throttle a StaticResponse | ||
e2e/e2e_cookies.cy.js • 1 flaky test • 5x-driver-firefox
| Test | ||
|---|---|---|
| e2e cookies spec > __Host- prefix > can set __Host- cookie | ||
e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | ||
|---|---|---|
| cy.origin assertions > #consoleProps > .should() and .and() | ||
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox
| Test | ||
|---|---|---|
| ... > correctly returns currentRetry | ||
| ... > correctly returns currentRetry | ||
| ... > correctly returns currentRetry | ||
e2e/origin/commands/navigation.cy.ts • 1 flaky test • 5x-driver-electron
| Test | ||
|---|---|---|
| cy.origin navigation > #consoleProps > .go() | ||
The first 5 flaky specs are shown, see all 20 specs in Cypress Cloud.
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
mschile
reviewed
Feb 21, 2023
mjhenkes
reviewed
Feb 21, 2023
| @@ -156,6 +158,54 @@ describe('lib/browsers/index', () => { | |||
| expect(err).to.have.property('message').to.contain(`Browser: ${chalk.yellow('foo-bad-bang')} was not found on your system`) | |||
| }) | |||
| }) | |||
|
|
|||
| // https://github.com/cypress-io/cypress/issues/24377 | |||
| it('kills browser if one connects while launching another instance', async () => { | |||
There was a problem hiding this comment.
impressive that you were able to reproduce this in a test!
mjhenkes
approved these changes
Feb 21, 2023
mschile
reviewed
Feb 21, 2023
mjhenkes
approved these changes
Feb 22, 2023
mschile
reviewed
Feb 22, 2023
mschile
reviewed
Feb 22, 2023
mschile
approved these changes
Feb 22, 2023
This was referenced Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
See the code comment in
browsers/index.ts.Steps to test
I was never able to reproduce the issue for this, so unfortunately it's not really possible to test it out manually.
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?