Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding beforeTest and AfterTest to protocol #26216

Merged
merged 12 commits into from
Mar 27, 2023

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Mar 24, 2023

Additional details

This PR adds the test:lifecycle start and end events to the protocol.

Steps to test

  • Clone the cypress-services repo and checkout mschile/protocol/add_before_after_test
    • Run yarn
    • Run yarn watch in packages/app-capture-protocol
  • Set CYPRESS_LOCAL_PROTOCOL_PATH to the path to cypress-services/packages/app-capture-protocol/dist/index.js
  • Clone the cypress repo and checkout mschile/protocol/before_after_test
    • Run yarn
    • Execute cypress run on a project in record mode with DEBUG set to cypress:*protocol* and ensure the test:lifecycle events are added to the database.

How has the user experience changed?

Screenshot 2023-03-24 at 12 19 24 PM

PR Tasks

@cypress
Copy link

cypress bot commented Mar 24, 2023

26 flaky tests on run #44965 ↗︎

0 26890 1281 0 Flakiness 26

Details:

fixing files spec
Project: cypress Commit: 765bb76cae
Status: Passed Duration: 19:31 💡
Started: Mar 27, 2023 3:25 PM Ended: Mar 27, 2023 3:44 PM
Flakiness  e2e/origin/user_agent_override.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
user agent override > persists modified user agent after cy.go Output Video
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox

View Output Video

Test Artifacts
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
Flakiness  create-from-component.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
... > runs generated spec Output Screenshots Video

The first 5 flaky specs are shown, see all 14 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@ryanthemanuel
Copy link
Collaborator

We should rename the tests directory to test. That appears to be the pattern in the monorepo.

@mschile
Copy link
Contributor Author

mschile commented Mar 27, 2023

We should rename the tests directory to test. That appears to be the pattern in the monorepo.

I see tests used more often in the repo.

@mschile mschile merged commit eed04d5 into feat/protocol Mar 27, 2023
@mschile mschile deleted the mschile/protocol/before_after_test branch March 27, 2023 17:14
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 29, 2023

Released in 13.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants