Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency: update dependency commander to v6.2.1 🌟 #26226

Merged
merged 5 commits into from
Apr 7, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 27, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
commander 6.1.0 -> 6.2.1 age adoption passing confidence
commander ^5.1.0 -> ^6.2.1 age adoption passing confidence

Release Notes

tj/commander.js

v6.2.1

Compare Source

Fixed
  • some tests failed if directory path included a space ([#​1390])

v6.2.0

Compare Source

Added
  • added 'tsx' file extension for stand-alone executable subcommands ([#​1368])
  • documented second parameter to .description() to describe command arguments ([#​1353])
  • documentation of special cases with options taking varying numbers of option-arguments ([#​1332])
  • documentation for terminology ([#​1361])
Fixed
  • add missing TypeScript definition for `.addHelpCommand()' ([#​1375])
  • removed blank line after "Arguments:" in help, to match "Options:" and "Commands:" ([#​1360])
Changed
  • update dependencies

Configuration

📅 Schedule: Branch creation - "before 5am every weekday" in timezone America/New_York, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

restoreEnv = null
}
})
;['--version', '-v', 'version'].forEach((versionCommand) => {
Copy link
Member

@emilyrohrbough emilyrohrbough Apr 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test coverage for all cypress command options to get the version:

cypress --version
cypress --version --component node

cypress -v
cypress --version --component electron

cypress version
cypress version --component node


os.platform.returns('darwin')
// sinon.stub(util, 'exit')
sinon.stub(util, 'logErrorExit1')
sinon.stub(util, 'logErrorExit1').returns(null)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct errors in CI from test_setup:
Screen Shot 2023-04-06 at 1 10 29 PM

@renovate
Copy link
Contributor Author

renovate bot commented Apr 6, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

}

handleVersion(program
.storeOptionsAsProperties()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using option --version/-v and using version as command is non longer supported and is considered "legacy".

'--component <package|binary|electron|node>', 'component to report version for',
)
.allowUnknownOption(true)
const parsed = versionParser.parse(args)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With how this was implemented to handle both cypress version --component XXX and cypress --version --component XXX, command v6 was throwing errors of command clashing because this adds support for --component at the top-level, where as its an option for the run and open commands.

@cypress
Copy link

cypress bot commented Apr 6, 2023

29 flaky tests on run #45326 ↗︎

0 26909 1281 0 Flakiness 29

Details:

remove unneeded snapshots
Project: cypress Commit: e773e64220
Status: Passed Duration: 20:09 💡
Started: Apr 6, 2023 7:50 PM Ended: Apr 6, 2023 8:10 PM
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
Flakiness  create-from-component.cy.ts • 2 flaky tests • app-e2e

View Output Video

Test Artifacts
... > runs generated spec Output Screenshots Video
... > runs generated spec Output Screenshots Video
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Output Screenshots Video
Flakiness  cypress-in-cypress-component.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
Cypress In Cypress CT > default config > redirects to the specs list with error if a spec is not found Output Screenshots Video
Flakiness  cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
Cypress In Cypress Origin Communicator > cy.origin passivity with app interactions > passes upon test reload mid test execution Output Screenshots Video

The first 5 flaky specs are shown, see all 16 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@AtofStryker
Copy link
Contributor

@emilyrohrbough do these snapshots still exist after the spec changes?

exports['cli --version no binary version 1'] = `
Cypress package version: 1.2.3
Cypress binary version: not installed
Electron version: not found
Bundled Node version: not found
`

exports['cli -v no binary version 1'] = `
Cypress package version: 1.2.3
Cypress binary version: not installed
Electron version: not found
Bundled Node version: not found
`

@emilyrohrbough
Copy link
Member

@AtofStryker NOPE, good call. I used the wrong ENV when running and those these were updated.

@emilyrohrbough emilyrohrbough merged commit 7311db0 into develop Apr 7, 2023
@emilyrohrbough emilyrohrbough deleted the renovate/commander-6.x branch April 7, 2023 14:52
astone123 pushed a commit to kgroat/cypress that referenced this pull request Apr 19, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Emily Rohrbough <emilyrohrbough@yahoo.com>
Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
renovate Triggered by renovatebot type: dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants