-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependency: update dependency commander to v6.2.1 🌟 #26226
Conversation
restoreEnv = null | ||
} | ||
}) | ||
;['--version', '-v', 'version'].forEach((versionCommand) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add test coverage for all cypress command options to get the version:
cypress --version
cypress --version --component node
cypress -v
cypress --version --component electron
cypress version
cypress version --component node
|
||
os.platform.returns('darwin') | ||
// sinon.stub(util, 'exit') | ||
sinon.stub(util, 'logErrorExit1') | ||
sinon.stub(util, 'logErrorExit1').returns(null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
} | ||
|
||
handleVersion(program | ||
.storeOptionsAsProperties() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using option --version/-v
and using version
as command is non longer supported and is considered "legacy".
'--component <package|binary|electron|node>', 'component to report version for', | ||
) | ||
.allowUnknownOption(true) | ||
const parsed = versionParser.parse(args) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With how this was implemented to handle both cypress version --component XXX
and cypress --version --component XXX
, command v6 was throwing errors of command clashing because this adds support for --component
at the top-level, where as its an option for the run
and open
commands.
@emilyrohrbough do these snapshots still exist after the spec changes?
|
@AtofStryker NOPE, good call. I used the wrong ENV when running and those these were updated. |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Emily Rohrbough <emilyrohrbough@yahoo.com> Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
This PR contains the following updates:
6.1.0
->6.2.1
^5.1.0
->^6.2.1
Release Notes
tj/commander.js
v6.2.1
Compare Source
Fixed
v6.2.0
Compare Source
Added
.description()
to describe command arguments ([#1353])Fixed
Changed
Configuration
📅 Schedule: Branch creation - "before 5am every weekday" in timezone America/New_York, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.