Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fixing percy flake by stopping time #26444

Merged
merged 2 commits into from
Apr 9, 2023

Conversation

warrensplayer
Copy link
Contributor

Additional details

Steps to test

Verify changed test runs and confirm Percy snapshots all have 01h 01m 02s for the duration time for the running build

How has the user experience changed?

N/A Just fixing a test

PR Tasks

@warrensplayer warrensplayer self-assigned this Apr 6, 2023
@cypress
Copy link

cypress bot commented Apr 6, 2023

30 flaky tests on run #45344 ↗︎

0 26909 1281 0 Flakiness 30

Details:

Merge branch 'develop' into stokes/flake_percy_debug_run_navigation
Project: cypress Commit: 8717feeffd
Status: Passed Duration: 19:03 💡
Started: Apr 7, 2023 6:53 PM Ended: Apr 7, 2023 7:12 PM
Flakiness  create-from-component.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
... > runs generated spec Output Screenshots Video
Flakiness  runner/reporter-ct-vite.errors.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
Vite - errors ui > cy.readFile Output Screenshots Video
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Output Screenshots Video
Flakiness  cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
Cypress In Cypress Origin Communicator > cy.origin passivity with app interactions > passes upon test reload mid test execution Output Screenshots Video
Flakiness  debug.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App - Debug Page > shows information about a failed spec Output Screenshots Video

The first 5 flaky specs are shown, see all 17 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@warrensplayer warrensplayer requested a review from a team April 6, 2023 16:20
Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@warrensplayer warrensplayer requested a review from a team April 7, 2023 13:19
@lmiller1990 lmiller1990 merged commit 7d935f6 into develop Apr 9, 2023
@lmiller1990 lmiller1990 deleted the stokes/flake_percy_debug_run_navigation branch April 9, 2023 23:00
astone123 pushed a commit to kgroat/cypress that referenced this pull request Apr 19, 2023
Co-authored-by: Mark Noonan <mark@cypress.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants