Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding wallClockUpdatedAt to log for protocol #26450

Merged
merged 5 commits into from
Apr 7, 2023

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Apr 6, 2023

Additional details

  • Adds a new property wallClockUpdatedAt to the log
    • Value is set to wallClockStartedAt for the first log and then updated when the log is updated

Steps to test

  • Clone the cypress-services repo and checkout mschile/protocol/command_log_timestamp
    • Run yarn
    • Run yarn watch-protocol
  • Set CYPRESS_LOCAL_PROTOCOL_PATH to the path to cypress-services/packages/app-capture-protocol/dist/index.js
  • Clone the cypress repo and checkout mschile/protocol/command_log_timestamp
    • Run yarn
    • Execute cypress run on a project in record mode with DEBUG set to cypress:*protocol* and ensure the command:log events with the correct timestamp are added to the database.

How has the user experience changed?

PR Tasks

@cypress
Copy link

cypress bot commented Apr 6, 2023

7 flaky tests on run #45330 ↗︎

0 4886 889 0 Flakiness 7

Details:

fix typescript issue
Project: cypress Commit: e431bebdd8
Status: Passed Duration: 16:04 💡
Started: Apr 7, 2023 3:34 AM Ended: Apr 7, 2023 3:50 AM
Flakiness  commands/net_stubbing.cy.ts • 3 flaky tests • 5x-driver-webkit

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output Video
... > with `times` > only uses each handler N times Output Video
... > stops waiting when an xhr request is canceled Output Video
Flakiness  commands/waiting.cy.js • 1 flaky test • 5x-driver-webkit

View Output Video

Test Artifacts
... > errors > throws when waiting on the 3rd request on array of aliases Output Video
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-webkit

View Output Video

Test Artifacts
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

packages/types/src/protocol.ts Show resolved Hide resolved
@ryanthemanuel
Copy link
Collaborator

Looks good. Nice work.

@mschile mschile merged commit 7f639b8 into feat/protocol Apr 7, 2023
@mschile mschile deleted the mschile/protocol/command_log_timestamp branch April 7, 2023 14:55
tgriesser added a commit that referenced this pull request Apr 11, 2023
* feat/protocol:
  chore: update vm2 to 3.9.15 (#26467)
  chore: adding wallClockUpdatedAt to log for protocol (#26450)
  chore: update protocol from develop (#26433)
  chore: adding command log to protocol (#26387)
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 29, 2023

Released in 13.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants