-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adding wallClockUpdatedAt to log for protocol #26450
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 flaky tests on run #45330 ↗︎
Details:
commands/net_stubbing.cy.ts • 3 flaky tests • 5x-driver-webkitcommands/waiting.cy.js • 1 flaky test • 5x-driver-webkit
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-webkit
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
AtofStryker
approved these changes
Apr 6, 2023
ryanthemanuel
approved these changes
Apr 7, 2023
Looks good. Nice work. |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
wallClockUpdatedAt
to the logwallClockStartedAt
for the first log and then updated when the log is updatedSteps to test
cypress-services
repo and checkoutmschile/protocol/command_log_timestamp
yarn
yarn watch-protocol
CYPRESS_LOCAL_PROTOCOL_PATH
to the path tocypress-services/packages/app-capture-protocol/dist/index.js
cypress
repo and checkoutmschile/protocol/command_log_timestamp
yarn
cypress run
on a project in record mode withDEBUG
set tocypress:*protocol*
and ensure thecommand:log
events with the correct timestamp are added to the database.How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?