fix: do not cache module resolution during launchpad dependency detection #26726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmiller1990
commented
May 11, 2023
| @@ -43,7 +43,7 @@ export async function isDependencyInstalled (dependency: Cypress.CypressComponen | |||
| // for module resolution. | |||
| const resolvePackagePath = require('resolve-package-path') | |||
|
|
|||
| const packageFilePath = resolvePackagePath(dependency.package, projectPath) | |||
| const packageFilePath = resolvePackagePath(dependency.package, projectPath, false) | |||
There was a problem hiding this comment.
This is the fix, the third arg is whether to cache or not - we don't want caching, or it won't find the dependency, even if the user adds it.
lmiller1990
commented
May 11, 2023
| @@ -8,8 +8,7 @@ | |||
| "preview": "vite preview" | |||
| }, | |||
| "dependencies": { | |||
| "react": "^18.0.0", | |||
| "react-dom": "^18.0.0" | |||
There was a problem hiding this comment.
Intentionally removed to reproduce issue in End to End test.
Passing run #46257 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
mike-plummer
approved these changes
May 11, 2023
packages/launchpad/cypress/e2e/scaffold-component-testing.cy.ts
Outdated
Show resolved
Hide resolved
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
We were caching the module resolution during the deps detection step, so even after installing a dep, we don't detect it - classic caching issue 🤦
Only an issue if a user is missing dependencies, which shouldn't be too common.
Steps to test
Repro in the original issue. I made a React/Vite project, removed
react-dom, then proceeded to setup Cypress CT. react-dom was not detected. I didyarn add react-domin the project, and now it is correctly detected.How has the user experience changed?
Correctly detects newly added dependencies during onboarding and shows user.
PR Tasks
cypress-documentation?type definitions?